1502525 - Consider reading extensions.webextensions.remote once

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[Rob Wu [:robwu]]

Our code is not designed to account for changes to the extensions.webextensions.remote preference when an extension has started.

Bug 1501375 is an example of a shutdown hang caused by an unexpected preference value flip.

We should consider reading the preference value only once (at start-up), and fix our tests to not rely on the ability to flip the preference value at runtime.

Comment 1

[Rob Wu [:robwu]]

This pref is probably going to be removed soon, when we drop (testing) support for in-process WebExtensions.

Comment 2

[Shane Caraveo (:mixedpuppy)]

(In reply to Rob Wu [:robwu] from comment #1)

This pref is probably going to be removed soon, when we drop (testing) support for in-process WebExtensions.

Do we have a bug on that, and is something for android blocking it?

Comment 3

[Rob Wu [:robwu]]

Attachment: Bug 1502525 - Remove runtime changes to remote extension pref in mochitests

The devtools tests are already unconditionally disabled (bug 1467313),
so there is no loss of coverage by removing the in-process test
scenario.

The other two tests already pass without disabling remote extensions.

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1502525 - Test to verify that mochitests run with in-process extensions

This is the counterpart to test_verify_remote_mode.html

Comment 5

[Rob Wu [:robwu]]

Attachment: Bug 1502525 - Read extensions.webextensions.remote once

Comment 6

[Rob Wu [:robwu]]

There will be a follow-up to remove support for the preference on desktop in bug 1613141.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82f81e2c5a27
Remove runtime changes to remote extension pref in mochitests r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/fd8ff6dd12db
Test to verify that mochitests run with in-process extensions r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/266c3a19fac5
Read extensions.webextensions.remote once r=mixedpuppy

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/82f81e2c5a27
https://hg.mozilla.org/mozilla-central/rev/fd8ff6dd12db
https://hg.mozilla.org/mozilla-central/rev/266c3a19fac5

Comment 9

[Miruna Curtean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added?

Thanks!

Comment 10

[Rob Wu [:robwu]]

Covered by automated tests.