Port bug 1502054 to TB: Remove the header-button class

RESOLVED FIXED in Thunderbird 65.0

Status

enhancement
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 65.0

Thunderbird Tracking Flags

(thunderbird_esr6063+ fixed, thunderbird64 fixed, thunderbird65 fixed)

Details

Attachments

(2 attachments)

Bug 1502054 removed the header-button class. We used it for the navigation buttons (forward/backward) in the Add-on manager.
This adds the needed rules to our files. On Windows without the patch you see a blueish background when hovering. Mac shows absolutely no difference when disabled or hovered without patch.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9020529 - Flags: review?(jorgk)
Comment on attachment 9020529 [details] [diff] [review]
1502616-nav-button.patch

Yes, that works fine for me. The arrow cursor turns onto a little hand again and the hover background is grey again.

BTW, there is a no hover background in TB 60 ESR. Is that a bug?
Attachment #9020529 - Flags: review?(jorgk) → review+
On ESR the hover background colour is the same we use to make the sidebar darker. I could make a patch with only the same hover colour we use here.
Keywords: checkin-needed
Maybe that would look better.
This should do it on ESR.
Attachment #9020563 - Flags: approval-comm-esr60?
Comment on attachment 9020563 [details] [diff] [review]
1502616-nav-button-ESR.patch

OK, I'll land this with the next lot, perhaps not for TB 60.3 any more. That applies to the beta as well in case we do TB 64 beta 2?
Attachment #9020563 - Flags: approval-comm-esr60? → approval-comm-esr60+
It should apply to beta. This file wasn't touched much.
Attachment #9020563 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/41cd1f527410
Fix our nav-button after removing the header-button class in bug 1502054. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.