Closed Bug 1502681 Opened 3 years ago Closed 3 years ago

Always use ProgramData\Mozilla\updates for the updates directory.

Categories

(Toolkit :: Application Update, defect)

59 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

After diagnosing bug 1501940 it became apparent that it would be best to always use ProgramData\Mozilla\updates. Doing so makes it much simpler to prevent security exploits and simplifies the code.
Depends on: 1458314
Comment on attachment 9020578 [details] [diff] [review]
patch rev 1

I also verified locally that the tests pass on Thunderbird.

The change to updater.cpp is to silence a build time warning about the function not being used on Windows.
Attachment #9020578 - Flags: review?(ksteuber)
Attachment #9020578 - Flags: review?(ksteuber) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3aa3bd3881a
Always use ProgramData\Mozilla\updates for the updates directory. r=bytesized
https://hg.mozilla.org/mozilla-central/rev/d3aa3bd3881a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.