Update common.css primary buttons according to photon spec

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P5
normal
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: ntim, Assigned: Matthias)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

They use a darker blue now.
Summary: Update primary buttons according to photon spec → Update common.css primary buttons according to photon spec
Priority: -- → P5
Do you also want to update the non-primary buttons?
And what about the ghost buttons? I used them for my mockup for the new about:config (Bug 1493439) but I'm not sure whether it's reasonable to add them for this one page...
Flags: needinfo?(ntim.bugs)
(In reply to :Matthias Kammüller from comment #2)
> Do you also want to update the non-primary buttons?

Yes, I think that's fine.

> And what about the ghost buttons? I used them for my mockup for the new
> about:config (Bug 1493439) but I'm not sure whether it's reasonable to add
> them for this one page...

I think it's fine to add a class for this in common.css, since I think it's likely going to be reused in the future.

Feel free to organize the patches however you like (everything in this bug, one button style per bug, ...), however it would be faster to update the primary buttons in this bug (since it's simply a matter of updating 3 CSS variables) and do your remaining changes in another one.
Flags: needinfo?(ntim.bugs)
Assignee: nobody → matthias
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a07b04b4483
photonized primary buttons. r=ntim,dao
https://hg.mozilla.org/mozilla-central/rev/0a07b04b4483
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.