1502686 - Race condition when enabling Fuzzyfox

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

When enabling fuzzyfox, if the JS Engine gets the current time before Fuzzyfox has run for the first time, we will return a completely old timestamp and are likely to cause a crash.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1502686 - When fuzzyfox is enabled, first put it into an initializing state before telling TimeStamp is it enabled r?baku

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 9022204 [details] [diff] [review]
Bug 1502686 - When fuzzyfox is enabled, first put it into an initializing state before telling TimeStamp is it enabled r?baku

Review of attachment 9022204 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/fuzzyfox/Fuzzyfox.cpp
@@ +236,5 @@
>    mStartTime = ActualTime();
>    mDuration = PickDuration();
>  
> +  LOG(Verbose, ("[FuzzyfoxEvent] PT(%p) For next time mDuration: %" PRIu32 " mStartTime: %" PRIu64 " \n",
> +         this, mDuration, mStartTime));

indentation here.

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1502686 - When fuzzyfox is enabled, first put it into an initializing state before telling TimeStamp is it enabled r=baku

carry forward r+ from comment 2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/582dbb4c3bf5
When fuzzyfox is enabled, first put it into an initializing state before telling TimeStamp is it enabled r=baku

Comment 5

[Arthur Iakab [arthur_iakab]]

Backed out changeset 582dbb4c3bf5 (bug 1502686)for failing gtests on Contents/Resources/gmp-clearkey "CLOSED TREE"

Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/9d77e7bc0c9354e0a184c5e67278eb202c9bf3ac

Backout push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=209505462&revision=9d77e7bc0c9354e0a184c5e67278eb202c9bf3ac

Failed push https://hg.mozilla.org/integration/mozilla-inbound/rev/582dbb4c3bf56b635ad6238e75e886cba720ecf7

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209504700&repo=mozilla-inbound

:tjr Could you please take a look?

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1502686 - When fuzzyfox is enabled, first put it into an initializing state before telling TimeStamp is it enabled r=baku

Carry forward r+

Patch adds a i != 0 condition to not crash gtest.  Sorry!

Comment 7

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Okay, got a try run that seems pretty good, a few failures that seem to be existing intermittents.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79fe86c6047b
When fuzzyfox is enabled, first put it into an initializing state before telling TimeStamp is it enabled r=baku

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/79fe86c6047b