1502721 - Crash in java.lang.NumberFormatException: at java.lang.Long.parseLong(Long.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-82295e7c-8310-414d-bce2-740de0181027.
=============================================================

Java stack trace:

java.lang.NumberFormatException
	at java.lang.Long.parseLong(Long.java:594)
	at java.lang.Long.valueOf(Long.java:808)
	at org.mozilla.gecko.util.ContentUriUtils.getPath(ContentUriUtils.java:67)
	at org.mozilla.gecko.util.FileUtils.getFilePathFromUri(FileUtils.java:291)
	at org.mozilla.gecko.IntentHelper.openNoHandler(IntentHelper.java:515)
	at org.mozilla.gecko.IntentHelper.handleMessage(IntentHelper.java:417)
	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:356)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6669)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:495)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

There are 3 crashes (from 1 installations) in nightly 64 starting with buildid 20181020102546. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1406903.
A similar issue with a potential fix can be found here:
https://github.com/Yalantis/uCrop/issues/318#issuecomment-333066640

[1] https://hg.mozilla.org/mozilla-central/rev?node=05d8e65ff651

Comment 1

[Jan Henning [:JanH]]

Backed out from Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/194d3585f3d567c047245c842ac5ee6b6390b474

Comment 2

[Andrei Lazar]

Attachment: Bug 1502721 Crash in java.lang.NumberFormatException: at java.lang.Long.parseLong(Long.java) r=JanH

Added catch for NumberFormatException that may be thrown when trying to open some downloaded files with Fennec.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

For the record, the code snippet landed in uCrop
https://github.com/Yalantis/uCrop/pull/337/files

Which is published under the Apache 2.0 license. Means that we can integrate it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fda62ff71b4
Crash in java.lang.NumberFormatException: at java.lang.Long.parseLong(Long.java) r=JanH

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9fda62ff71b4