Closed Bug 1502721 Opened 11 months ago Closed 10 months ago

Crash in java.lang.NumberFormatException: at java.lang.Long.parseLong(Long.java)

Categories

(Firefox for Android :: General, defect, P1, critical)

Firefox 65
Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- disabled
firefox65 --- fixed

People

(Reporter: calixte, Assigned: andrei.a.lazar)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-82295e7c-8310-414d-bce2-740de0181027.
=============================================================

Java stack trace:

java.lang.NumberFormatException
	at java.lang.Long.parseLong(Long.java:594)
	at java.lang.Long.valueOf(Long.java:808)
	at org.mozilla.gecko.util.ContentUriUtils.getPath(ContentUriUtils.java:67)
	at org.mozilla.gecko.util.FileUtils.getFilePathFromUri(FileUtils.java:291)
	at org.mozilla.gecko.IntentHelper.openNoHandler(IntentHelper.java:515)
	at org.mozilla.gecko.IntentHelper.handleMessage(IntentHelper.java:417)
	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:356)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6669)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:495)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

There are 3 crashes (from 1 installations) in nightly 64 starting with buildid 20181020102546. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1406903.
A similar issue with a potential fix can be found here:
https://github.com/Yalantis/uCrop/issues/318#issuecomment-333066640

[1] https://hg.mozilla.org/mozilla-central/rev?node=05d8e65ff651
Flags: needinfo?(andrei.a.lazar)
Assignee: nobody → andrei.a.lazar
Flags: needinfo?(andrei.a.lazar)
Priority: -- → P1
Added catch for NumberFormatException that may be thrown when trying to open some downloaded files with Fennec.
For the record, the code snippet landed in uCrop
https://github.com/Yalantis/uCrop/pull/337/files

Which is published under the Apache 2.0 license. Means that we can integrate it.
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fda62ff71b4
Crash in java.lang.NumberFormatException: at java.lang.Long.parseLong(Long.java) r=JanH
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9fda62ff71b4
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.