Closed Bug 1502722 Opened 6 years ago Closed 6 years ago

Port bug 1501586 to TB: Clean up lwt-*-brighttext attributes properly when switching from a dark theme to a light theme

Categories

(Thunderbird :: Theme, task)

Product:
Thunderbird
Component:
Theme
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(thunderbird64 fixed, thunderbird65 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 65.0
Tracking Flags:
Tracking Status
thunderbird64 --- fixed
thunderbird65 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

1502722-lwt-tree-variable-cleanup.patch
1.07 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
sidebarScrollbarsColor.patch only for testing the fix
6.27 KB, patch
Details | Diff | Splinter Review 
With a dark theme applied that uses the sidebar colours and then switching to a light theme using the sidebar colours, the lwt-tree-brighttext attribute isn't removed.
This is a port of https://hg.mozilla.org/integration/autoland/rev/a2b59c32f04d

You don't see a difference now when switching from dark theme to WE-Nuvola actually because we don't use such visible elements. I'll attach a patch to show themed scrollbars in the folderPane tree there you will see the effect.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9020602 - Flags: review?(jorgk)
Attachment #9020602 - Flags: approval-comm-beta?
This patch will land in a new bug but isn't ready because under Windows the scrollbar arrows are almost or not visible and I wait for the fix in bug 1485599 to follow.
Comment on attachment 9020602 [details] [diff] [review]
1502722-lwt-tree-variable-cleanup.patch

This looks very reasonable by code inspection, especially as a port. Sorry, I didn't test it.
Attachment #9020602 - Flags: review?(jorgk)
Attachment #9020602 - Flags: review+
Attachment #9020602 - Flags: approval-comm-beta?
Attachment #9020602 - Flags: approval-comm-beta+
Keywords: checkin-needed
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4a6558329193
Port bug 1501586 to TB: Clean up lwt-*-brighttext attributes properly when switching from a dark theme to a light theme. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: