1502736 - Impossible to write text on input field

Status: RESOLVED INVALID

(Core :: DOM: Events, defect)

Description

[freerider74]

Attachment: test.html

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce:

Works with version 62.0.3 and previous.
Do not work on version 63 and 64beta.

Open attached html file.
Enter value in the text field.
A javascript controled the entered value.

Info : This in not my code (heating system for home), I just successfully isolated the cell and the javascript function.


Actual results:

In version 63 : It is not possible to write any caracters
In version 62 : numbers are correctly written

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: Web site input form does not work

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=72c2fc2d0ab17a10c5540714c82739fb346b0088&tochange=70767540914776745f09d26af6a4d20dfd15f855

Regressed by: 707675409147	Alphan Chen — Bug 1452569 - Implement Event's returnValue. r=smaug

@Alphan,
Your patch seems to cause the regression. Could you please look into this?

Comment 2

[Alphan Chen [:alchen]]

Attachment: Revisedtest.html

Comment 3

[Alphan Chen [:alchen]]

I don't think it is a regression.
After checking attachment 9020624 [details], I think there is a logic error in it.
On Firefox, if we try to enter number(0-9) into the input field, it will set "event.returnValue" to false and also set cancelBubble to true.
This is not a behavior we want.
The reason why it works is FF don't implement returnvalue before bug 1452569.
So it won't have any effect when setting returnvalue.


I will revise the code like attachment 9020728 [details].
Here is its spirit.
1. if there is "keyCode", check the value of "keycode".
2. If there is no keyCode, check if there is "which".
   2-1 If there is which, check the value of "which"

Comment 4

[Alphan Chen [:alchen]]

Currently, there is no "keycode" in the "keypress" event.
It may be caused by bug 1479964.

Comment 5

[freerider74]

Ok, I'll try to explain to people who made this code that it's not a correct way.