1502774 - Remove XPCOM registrations for HTTP authenticators and auth modules

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Comment 1

[(no longer active)]

Attachment: Bug 1502774 - Part 1: Remove XPCOM component registrations for HTTP authenticator classes

Comment 2

[(no longer active)]

Attachment: Bug 1502774 - Part 2: Remove XPCOM component registrations for auth module classes

Depends on D10025

Comment 3

[(no longer active)]

Attachment: Bug 1502774 - Part 3: Remove nsAuthModule

Depends on D10026

Comment 4

[Honza Bambas (:mayhemer)]

Please cc me next time on http authentication bugs.  Thanks.

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for 

Backout link: https://hg.mozilla.org/integration/autoland/rev/af20bba72e84ae85bcf3bdbb65f4bcdb1e8c1dc5
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&classifiedState=unclassified&selectedJob=208384006&revision=a1f9c46668550d18322337e43b361e48a28694dd
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=208384006&repo=autoland&lineNumber=13626

Comment 6

[Narcis Beleuzu [:NarcisB]]

...Backed out for mingwclang bustages on include/sspi.h

Comment 7

[Narcis Beleuzu [:NarcisB]]

There were also bustages on Unified_cpp_extensions_auth0.obj 
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=208383997&repo=autoland&lineNumber=16392

Comment 8

[(no longer active)]

(In reply to Honza Bambas (:mayhemer) from comment #4)
> Please cc me next time on http authentication bugs.  Thanks.

Sure, will do.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b403c3c786ee
Part 1: Remove XPCOM component registrations for HTTP authenticator classes r=valentin
https://hg.mozilla.org/integration/autoland/rev/07648e9d8400
Part 2: Remove XPCOM component registrations for auth module classes r=valentin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32a581482291
Part 1: Remove XPCOM component registrations for HTTP authenticator classes r=valentin
https://hg.mozilla.org/integration/autoland/rev/b3bf57d996a7
Part 2: Remove XPCOM component registrations for auth module classes r=valentin
https://hg.mozilla.org/integration/autoland/rev/6b821f5b12ae
Part 3: Remove nsAuthModule r=valentin

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/32a581482291
https://hg.mozilla.org/mozilla-central/rev/b3bf57d996a7
https://hg.mozilla.org/mozilla-central/rev/6b821f5b12ae

Comment 12

[Andreea Pavel [:apavel]]

Backed out for causing multiple crashes - Bug 1503201 

Backout: https://hg.mozilla.org/mozilla-central/rev/c2b537178ae9cb4ee0c8afbc1504f97159a7aed5

Comment 13

[(no longer active)]

The crash in bug 1503201 can be reproduced on https://jigsaw.w3.org/HTTP/Digest/ after entering "guest" as both user name and password.

Comment 14

[(no longer active)]

A better place to reproduce the bug is actually https://www.xda-developers.com/huawei-gopro-quik/.

On that page we end up getting a resource with the following string as the auth challenge: "Bearer realm=\"XDA\"".  This gives us the "bearer" authType, which isn't a real auth type.  Here, we fail with the NS_ERROR_SERVICE_NOT_FOUND error code.

*But*, and here is the source of our bug, NS_ERROR_SERVICE_NOT_FOUND is _not_ an error code, as it turns out, it is a _success_ code: https://searchfox.org/mozilla-central/rev/fc3d974254660b34638b2af9d5431618b191b233/xpcom/base/ErrorList.py#183

It seems to be used for the case where the XPCOM factory has returned a success error code, without returning an object: https://searchfox.org/mozilla-central/rev/fc3d974254660b34638b2af9d5431618b191b233/xpcom/components/nsComponentManager.cpp#1048.  As a result, this NS_SUCCEEDED check <https://searchfox.org/mozilla-central/rev/fc3d974254660b34638b2af9d5431618b191b233/netwerk/protocol/http/nsHttpChannelAuthProvider.cpp#588> would pass and we'd fall into this branch here where |auth| would be null which would cause the crash: <https://searchfox.org/mozilla-central/rev/fc3d974254660b34638b2af9d5431618b191b233/netwerk/protocol/http/nsHttpChannelAuthProvider.cpp#612>.

Passing the correct XPCOM error code which is NS_ERROR_FACTORY_NOT_REGISTERED fixes the crash.

Comment 15

[Honza Bambas (:mayhemer)]

(In reply to :Ehsan Akhgari from comment #14)
> *But*, and here is the source of our bug, NS_ERROR_SERVICE_NOT_FOUND is
> _not_ an error code,

It would really not come through my mind to look at that error code declaration :D  Good to know.

Comment 16

[Masatoshi Kimura [:emk]]

NS_ERROR_SERVICE_NOT_FOUND has been removed by bug 497136.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53675535f504
Part 1: Remove XPCOM component registrations for HTTP authenticator classes r=valentin
https://hg.mozilla.org/integration/autoland/rev/5662f3757fb4
Part 2: Remove XPCOM component registrations for auth module classes r=valentin
https://hg.mozilla.org/integration/autoland/rev/32c4433496ab
Part 3: Remove nsAuthModule r=valentin

Comment 18

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/53675535f504
https://hg.mozilla.org/mozilla-central/rev/5662f3757fb4
https://hg.mozilla.org/mozilla-central/rev/32c4433496ab