1502812 - Sideloaded add-on prompt doesn't ask to restart

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, enhancement)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1502812-sideload-restart-1.diff

I had been ignoring this bug because I don't think it's that important, but it probably should be fixed.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9060003 [details] [diff] [review]
1502812-sideload-restart-1.diff

Review of attachment 9060003 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/modules/ExtensionsUI.jsm
@@ +705,5 @@
> +    let list = document.getElementById("addon-installed-list");
> +    list.hidden = false;
> +    while (list.firstChild) {
> +      list.firstChild.remove();
> +    }

why not show later when the children were removed?

Comment 3

[Geoff Lankow (:darktrojan)]

Do you mean why I don't do list.hidden = false later? It doesn't matter, none of this UI is displayed until the end of the function.

Comment 4

[Magnus Melin [:mkmelin]]

Yes that was what I was asking. I guess it's doesn't matter much then.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4965f8d61f03
Confirm installation of sideloaded add-ons, and prompt to restart if necessary. r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d530d815c296
follow-up - Fix a basic error in logic; rs=me DONTBUILD

Comment 7

[Jorg K (CEST = GMT+2)]

That needs to land on beta, right?

Comment 8

[Geoff Lankow (:darktrojan)]

Yes. Fix my silly mistake everywhere.

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: d530d815c296

Comment 10

[Jorg K (CEST = GMT+2)]

TB 68 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/22fa2d4b9a3064540b58c2d9686423a5c4bbbaf0