Closed Bug 1502812 Opened 2 years ago Closed 1 year ago

Sideloaded add-on prompt doesn't ask to restart

Categories

(Thunderbird :: Add-Ons: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(2 files)

No description provided.
Assignee: geoff → nobody
Flags: needinfo?(geoff)

I had been ignoring this bug because I don't think it's that important, but it probably should be fixed.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Attachment #9060003 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9060003 [details] [diff] [review]
1502812-sideload-restart-1.diff

Review of attachment 9060003 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/modules/ExtensionsUI.jsm
@@ +705,5 @@
> +    let list = document.getElementById("addon-installed-list");
> +    list.hidden = false;
> +    while (list.firstChild) {
> +      list.firstChild.remove();
> +    }

why not show later when the children were removed?
Attachment #9060003 - Flags: review?(mkmelin+mozilla) → review+

Do you mean why I don't do list.hidden = false later? It doesn't matter, none of this UI is displayed until the end of the function.

Yes that was what I was asking. I guess it's doesn't matter much then.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4965f8d61f03
Confirm installation of sideloaded add-ons, and prompt to restart if necessary. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d530d815c296
follow-up - Fix a basic error in logic; rs=me DONTBUILD

That needs to land on beta, right?

Flags: needinfo?(geoff)

Yes. Fix my silly mistake everywhere.

Flags: needinfo?(geoff)
Attached patch d530d815c296Splinter Review
Attachment #9075320 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.