Closed
Bug 1502857
Opened 6 years ago
Closed 6 years ago
Refactor loading tools in Inspector sidebar
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox65 fixed)
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
Details
Attachments
(1 file)
- removes duplication of logic to create each panel. - removes needless exposing of panel instances as properties on `inspector`: - `inspector.layoutview` - `inspector.fontinspector` - `inspector.animationinspector` - `inspector.changesview` - updates tests to not rely on those exposed properties and instead call `inspector.getPanel(toolId)` (previously created panels are stored and a reference is returned). - consolidates panel `destroy()` so we don't have to remember to destroy them individually.
Assignee | ||
Comment 1•6 years ago
|
||
- removes duplication of logic to create each panel. - removes needless exposing of panel instances as properties on `inspector`: - `inspector.layoutview` - `inspector.fontinspector` - `inspector.animationinspector` - `inspector.changesview` - updates tests to not rely on those exposed properties and instead call `inspector.getPanel(toolId)` (previously created panels are stored and a reference is returned). - consolidates panel `destroy()` so we don't have to remember to destroy them individually. MozReview-Commit-ID: GVkP6z7FxKt
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b832377ab7a5 Refactor loading tools in Inspector sidebar; r=gl
Comment 3•6 years ago
|
||
Backed out changeset b832377ab7a5 (bug 1502857) for dt failures on browser_inspector_extension_sidebar.js and browser_fontinspector.js CLOSED TREE Backout revision https://hg.mozilla.org/integration/autoland/rev/50eb173f1bc2b8e8ce2921fcfd53a714e40dcab1 Failed push: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b832377ab7a5642158f81e34c74f1f079c8bb3b3 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209824677&repo=autoland for dt4 https://treeherder.mozilla.org/logviewer.html#?job_id=209820874&repo=autoland for dt2 :rcaliman could you please take a look?
Flags: needinfo?(rcaliman)
Assignee | ||
Comment 4•6 years ago
|
||
There was an uncaught promise rejection which triggered the failure. Fixed and pushed to try to validate: https://treeherder.mozilla.org/#/jobs?repo=try&revision=45cc9127c594885c4eb6546e1caa24ac64384aae Once confirmed, I'l reattempt landing.
Flags: needinfo?(rcaliman)
Assignee | ||
Comment 5•6 years ago
|
||
Another try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c86dabbd35c833869672d67287906d6c14d8d6f3
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48bcca6536ed Refactor loading tools in Inspector sidebar; r=gl
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/48bcca6536ed
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•