Refactor loading tools in Inspector sidebar

RESOLVED FIXED in Firefox 65

Status

enhancement
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: rcaliman, Assigned: rcaliman)

Tracking

unspecified
Firefox 65
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

- removes duplication of logic to create each panel.
- removes needless exposing of panel instances as properties on `inspector`:
  - `inspector.layoutview`
  - `inspector.fontinspector`
  - `inspector.animationinspector`
  - `inspector.changesview`
- updates tests to not rely on those exposed properties and instead call `inspector.getPanel(toolId)` (previously created panels are stored and a reference is returned).
- consolidates panel `destroy()` so we don't have to remember to destroy them individually.
- removes duplication of logic to create each panel.
- removes needless exposing of panel instances as properties on `inspector`:
  - `inspector.layoutview`
  - `inspector.fontinspector`
  - `inspector.animationinspector`
  - `inspector.changesview`
- updates tests to not rely on those exposed properties and instead
call `inspector.getPanel(toolId)` (previously created panels are stored
and a reference is returned).
- consolidates panel `destroy()` so we don't have to remember to
destroy them individually.

MozReview-Commit-ID: GVkP6z7FxKt
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b832377ab7a5
Refactor loading tools in Inspector sidebar; r=gl
There was an uncaught promise rejection which triggered the failure. Fixed and pushed to try to validate:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=45cc9127c594885c4eb6546e1caa24ac64384aae

Once confirmed, I'l reattempt landing.
Flags: needinfo?(rcaliman)
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48bcca6536ed
Refactor loading tools in Inspector sidebar; r=gl
https://hg.mozilla.org/mozilla-central/rev/48bcca6536ed
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.