Closed Bug 1502873 Opened 1 year ago Closed 1 year ago

More tweaks for raptor gecko profiling support

Categories

(Testing :: Raptor, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: rwood, Assigned: rwood)

References

Details

Attachments

(1 file)

Gecko profiling support in Raptor needs more tweaks, see:

https://bugzilla.mozilla.org/show_bug.cgi?id=1473079#c29
Assignee: nobody → rwood
Status: NEW → ASSIGNED
(In reply to Robert Wood [:rwood] from comment #3)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab7afb4e7b9e9b29602088ed88f716f5456f0fab

Hey Markus, this patch stops/starts the profiler between pagecycles (and has increased entries). Looks better to me - would you mind having a quick look at some profiles on this ^ try run and confirm they look better now? Thanks!
Flags: needinfo?(mstange)
The starting and stopping seems to work correctly.

But I can still see lots of profiles that are incomplete due to a too small buffer size. I think the number of entries needs to be increased even more.
Flags: needinfo?(mstange)
(In reply to Markus Stange [:mstange] from comment #5)

Thanks Markus - ok, yes I see what you mean. I will keep increasing entries and re-trying until the profiles are complete.
(In reply to Robert Wood [:rwood] from comment #6)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=576003b1c35994e7cdc28fd7bd6377bb289e117d

I went through all profiles for all the raptor jobs on osx and win10; looking for 'sendResult' inside the gecko profile (that is called in raptor for each measurement taken in pageload tests, and once for the benchmark tests).

Still have to increase gecko profile entries for the following:

gdocs (all pages)
tp6 (all pages)
wasm godot

Note: raptor wm, wm-b, wm-i (wasm.. tests only on linux) don't even show any content thread in the profiles. Not worrying about that for now.
Blocks: 1503398
I don't think I'm reading these right, sometimes I can find 'sendResult' but not everytime even with a huge number of entries. I'm just going to land this after this next try run. However if it is found that some profiles generated by raptor tests are not sufficient, please feel free to file bugs against that specific test, with suggestions for the gecko profile buffer/number of entries, thanks!
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2150b1a32179
More tweaks for raptor gecko profiling support; r=jmaher
https://hg.mozilla.org/mozilla-central/rev/2150b1a32179
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.