1502873 - More tweaks for raptor gecko profiling support

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement)

Description

[Robert Wood [:rwood]]

Gecko profiling support in Raptor needs more tweaks, see:

https://bugzilla.mozilla.org/show_bug.cgi?id=1473079#c29

Comment 1

[Robert Wood [:rwood]]

Attachment: Bug 1502873 - More tweaks for raptor gecko profiling support; r?jmaher

Comment 2

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fdcc92923c218e6431b4d5224572264b19c3509

Comment 3

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab7afb4e7b9e9b29602088ed88f716f5456f0fab

Comment 4

[Robert Wood [:rwood]]

(In reply to Robert Wood [:rwood] from comment #3)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab7afb4e7b9e9b29602088ed88f716f5456f0fab

Hey Markus, this patch stops/starts the profiler between pagecycles (and has increased entries). Looks better to me - would you mind having a quick look at some profiles on this ^ try run and confirm they look better now? Thanks!

Comment 5

[Markus Stange [:mstange]]

The starting and stopping seems to work correctly.

But I can still see lots of profiles that are incomplete due to a too small buffer size. I think the number of entries needs to be increased even more.

Comment 6

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=576003b1c35994e7cdc28fd7bd6377bb289e117d

Comment 7

[Robert Wood [:rwood]]

(In reply to Markus Stange [:mstange] from comment #5)

Thanks Markus - ok, yes I see what you mean. I will keep increasing entries and re-trying until the profiles are complete.

Comment 8

[Robert Wood [:rwood]]

(In reply to Robert Wood [:rwood] from comment #6)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=576003b1c35994e7cdc28fd7bd6377bb289e117d

I went through all profiles for all the raptor jobs on osx and win10; looking for 'sendResult' inside the gecko profile (that is called in raptor for each measurement taken in pageload tests, and once for the benchmark tests).

Still have to increase gecko profile entries for the following:

gdocs (all pages)
tp6 (all pages)
wasm godot

Note: raptor wm, wm-b, wm-i (wasm.. tests only on linux) don't even show any content thread in the profiles. Not worrying about that for now.

Comment 9

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c350bf15e14850a137430f3f8e5e537dc6ac442

Comment 10

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=58a2ee8c399c37632661bed442e6536d102b708d

Comment 11

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3dbe9ec45a098f1b29bf543517f678cdec4c8989

Comment 12

[Robert Wood [:rwood]]

I don't think I'm reading these right, sometimes I can find 'sendResult' but not everytime even with a huge number of entries. I'm just going to land this after this next try run. However if it is found that some profiles generated by raptor tests are not sufficient, please feel free to file bugs against that specific test, with suggestions for the gecko profile buffer/number of entries, thanks!

Comment 13

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=efa9a43bd563c3157d624026ae72c040c9db9c9c

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2150b1a32179
More tweaks for raptor gecko profiling support; r=jmaher

Comment 15

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/2150b1a32179