1502875 - Remove XULDocument::AddSubtreeToDocumentPre.

Status: RESOLVED FIXED

(Core :: XUL, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

BindToTree takes care of adding to the ID table.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1502875 - Remove AddElementToDocumentPre and RemoveSubtreeFromDocument. r=smaug

The ID table is managed in BindToTree / UnbindFromTree.

I guess this was more important when XUL templates were a thing.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1502875 - Simplify AddIdElement. r=smaug

Comment 3

[Brian Grinstead [:bgrins]]

Not sure if it's related to this, but we've been finding and removing cases where we were relying on `document.getElementById("foo")` traversing into XBL anon content (bug 1502151, bug 1500240), since that doesn't work in HTML documents. As far as I know there aren't any more places where we do that, and if there are we can remove them.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

(In reply to Brian Grinstead [:bgrins] from comment #3)
> Not sure if it's related to this, but we've been finding and removing cases
> where we were relying on `document.getElementById("foo")` traversing into
> XBL anon content (bug 1502151, bug 1500240), since that doesn't work in HTML
> documents. As far as I know there aren't any more places where we do that,
> and if there are we can remove them.

Oh, that's awesome.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1502875 - Don't let GetElementById work across anonymous subtree boundaries in XUL documents. r=smaug

According to comment 3 the front-end no longer needs it.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)
> Created attachment 9020811 [details]
> Bug 1502875 - Don't let GetElementById work across anonymous subtree
> boundaries in XUL documents. r=smaug
> 
> According to comment 3 the front-end no longer needs it.

Richard, if TB is relying on document.getElementById traversing into XBL content, behavior can be restored by using something like `document.getAnonymousElementByAttribute(xblHostElement, "id", id)` (see bug 1502151 and bug 1500240).

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1502875 - Don't call AddToIdTable when moving around a shadow root. r=smaug

This is needed to make the "Simplify AddToIdTable" patch work. I'll
land it before that one.

Comment 8

[Richard Marti (:Paenglab)]

(In reply to Brian Grinstead [:bgrins] from comment #6)
> (In reply to Emilio Cobos Álvarez (:emilio) from comment #5)
> > Created attachment 9020811 [details]
> > Bug 1502875 - Don't let GetElementById work across anonymous subtree
> > boundaries in XUL documents. r=smaug
> > 
> > According to comment 3 the front-end no longer needs it.
> 
> Richard, if TB is relying on document.getElementById traversing into XBL
> content, behavior can be restored by using something like
> `document.getAnonymousElementByAttribute(xblHostElement, "id", id)` (see bug
> 1502151 and bug 1500240).

Thank you for the heads-up, Brian. I'll n-i other c-c people which know this a lot better than me.

Comment 9

[:aceman]

Thank you. We know that you need to use getAnonymousElementByAttribute() to get an anonymous element so if there is use of getElementById instead, it should be by mistake and we will fix it.

I'll do some test run asserting when there is an ID and IsInAnonymousSubtree().

Comment 10

[:aceman]

I have created bug 1502997 for the cases found in Thunderbird.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb863c8de93f0d7ebd6ab1d53861ff7ecb227028

Looks much greener.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fb88c6c2223
Remove AddElementToDocumentPre and RemoveSubtreeFromDocument. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a38544a9172
Don't call AddToIdTable when moving around a shadow root. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/8157760bbde1
Simplify AddIdElement. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7a966ea9ad3
Don't let GetElementById work across anonymous subtree boundaries in XUL documents. r=smaug

Comment 13

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4fb88c6c2223
https://hg.mozilla.org/mozilla-central/rev/7a38544a9172
https://hg.mozilla.org/mozilla-central/rev/8157760bbde1
https://hg.mozilla.org/mozilla-central/rev/b7a966ea9ad3