Closed
Bug 1502879
Opened 6 years ago
Closed 6 years ago
Wrap UnifiedComplete in a Provider
Categories
(Firefox :: Address Bar, enhancement, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
It should be possible to wrap the existing unifiedComplete in a provider, this would allow to check for missing arguments and APIs, and would help hammering down view bugs and behaviors. This requires a translation level from queryContext to the actual input (likely we'll have to introduce a previousContext that is cleared on tabContextChanged) and for old result/actionuris to new match types.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 years ago
|
||
I have something working, but I'm not satisfied with one of the changes I made, I'll undo that, anyway this should be ready for review very soon. No tests for now, I'm not sure it's worth considered this is an interim situation and the existing UC has lots of tests. Once we have a muxer it could make more sense.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/ce090b99cf41 Wrap UnifiedComplete in a Provider. r=adw
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ce090b99cf41
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•