Wrap UnifiedComplete in a Provider

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P2
normal
RESOLVED FIXED
7 months ago
4 months ago

People

(Reporter: mak, Assigned: mak)

Tracking

(Blocks 1 bug)

unspecified
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Assignee

Description

7 months ago
It should be possible to wrap the existing unifiedComplete in a provider, this would allow to check for missing arguments and APIs, and would help hammering down view bugs and behaviors.
This requires a translation level from queryContext to the actual input (likely we'll have to introduce a previousContext that is cleared on tabContextChanged) and for old result/actionuris to new match types.
Assignee

Updated

7 months ago
Depends on: 1496685
Assignee

Updated

6 months ago
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Assignee

Comment 1

6 months ago
I have something working, but I'm not satisfied with one of the changes I made, I'll undo that, anyway this should be ready for review very soon. No tests for now, I'm not sure it's worth considered this is an interim situation and the existing UC has lots of tests. Once we have a muxer it could make more sense.

Comment 3

6 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/ce090b99cf41
Wrap UnifiedComplete in a Provider. r=adw

Comment 4

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ce090b99cf41
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Depends on: 1520833
You need to log in before you can comment on or make changes to this bug.