Closed Bug 1502879 Opened 2 years ago Closed 2 years ago
Complete in a Provider
47 bytes, text/x-phabricator-request
|Details | Review|
It should be possible to wrap the existing unifiedComplete in a provider, this would allow to check for missing arguments and APIs, and would help hammering down view bugs and behaviors. This requires a translation level from queryContext to the actual input (likely we'll have to introduce a previousContext that is cleared on tabContextChanged) and for old result/actionuris to new match types.
I have something working, but I'm not satisfied with one of the changes I made, I'll undo that, anyway this should be ready for review very soon. No tests for now, I'm not sure it's worth considered this is an interim situation and the existing UC has lots of tests. Once we have a muxer it could make more sense.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/ce090b99cf41 Wrap UnifiedComplete in a Provider. r=adw
You need to log in before you can comment on or make changes to this bug.