Closed
Bug 1502887
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 13761 - [css-properties-values-api] Proper computed value for <color>.
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 13761 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/13761 Details from upstream follow. Anders Hartvoll Ruud <andruud@chromium.org> wrote: > [css-properties-values-api] Proper computed value for <color>. > > As of an imminent spec change, \<color> values no longer compute to their > specified value, but behave like \<color> values in general. > > Note that color keywords are parsed as CSSIdentifierValue (holding a > CSSValueID), and custom idents are parsed as CSSCustomIdentValue (holding a > String), which is why the "tomato | \<color>" works as it should. > > R=futhark@chromium.org > > Bug: 641877 > Change-Id: I946536a9d54dbaa7af589cb99acdba72f37fe016 > Reviewed-on: https://chromium-review.googlesource.com/1303365 > WPT-Export-Revision: e33dc717483a3c3dbe0a8afec94edfb738891437
Assignee | ||
Comment 1•5 years ago
|
||
PR 13761 applied with additional changes from upstream: 979839c026d9a272a0c5c09097b92b74b00ff90e
Assignee | ||
Updated•5 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbc6e66913c8457e927af8ca4dbdc4cfc60ce39b
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a17cca1b909b84eb48c33f2d84f9abd8eb64ef3b
Assignee | ||
Comment 4•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b53476040758c333f89b0f2e40d0e6edc53a8fe2
Assignee | ||
Comment 5•5 years ago
|
||
Ran 3 tests and 30 subtests OK : 3 PASS : 1 FAIL : 29 New tests that have failures or other problems: /css/css-properties-values-api/registered-property-computation.html <color> values are computed correctly for divWithFontSizeInherited: FAIL <color> values are computed correctly for divWithFontSizeSet: FAIL <integer> values are computed correctly for divWithFontSizeInherited: FAIL <integer> values are computed correctly for divWithFontSizeSet: FAIL <integer>+ values are computed correctly for divWithFontSizeInherited: FAIL <integer>+ values are computed correctly for divWithFontSizeSet: FAIL ident values that look like color keywords are not converted to colorsdivWithFontSizeInherited: FAIL ident values that look like color keywords are not converted to colorsdivWithFontSizeSet: FAIL
Assignee | ||
Comment 6•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=946ee39650179d5cc15355235ae90e1e48783152
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e77decfb1e9 [wpt PR 13761] - [css-properties-values-api] Proper computed value for <color>., a=testonly
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e77decfb1e9
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•