1502887 - [wpt-sync] Sync PR 13761 - [css-properties-values-api] Proper computed value for <color>.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13761 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13761
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:
>  [css-properties-values-api] Proper computed value for <color>.
>  
>  As of an imminent spec change, \<color> values no longer compute to their
>  specified value, but behave like \<color> values in general.
>  
>  Note that color keywords are parsed as CSSIdentifierValue (holding a
>  CSSValueID), and custom idents are parsed as CSSCustomIdentValue (holding a
>  String), which is why the "tomato | \<color>" works as it should.
>  
>  R=[e-mail]
>  
>  Bug: 641877
>  Change-Id: I946536a9d54dbaa7af589cb99acdba72f37fe016
>  Reviewed-on: https://chromium-review.googlesource.com/1303365
>  WPT-Export-Revision: e33dc717483a3c3dbe0a8afec94edfb738891437

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 13761 applied with additional changes from upstream: 979839c026d9a272a0c5c09097b92b74b00ff90e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbc6e66913c8457e927af8ca4dbdc4cfc60ce39b

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a17cca1b909b84eb48c33f2d84f9abd8eb64ef3b

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b53476040758c333f89b0f2e40d0e6edc53a8fe2

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 3 tests and 30 subtests
OK     : 3
PASS   : 1
FAIL   : 29

New tests that have failures or other problems:
/css/css-properties-values-api/registered-property-computation.html
    <color> values are computed correctly for divWithFontSizeInherited: FAIL
    <color> values are computed correctly for divWithFontSizeSet: FAIL
    <integer> values are computed correctly for divWithFontSizeInherited: FAIL
    <integer> values are computed correctly for divWithFontSizeSet: FAIL
    <integer>+ values are computed correctly for divWithFontSizeInherited: FAIL
    <integer>+ values are computed correctly for divWithFontSizeSet: FAIL
    ident values that look like color keywords are not converted to colorsdivWithFontSizeInherited: FAIL
    ident values that look like color keywords are not converted to colorsdivWithFontSizeSet: FAIL

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=946ee39650179d5cc15355235ae90e1e48783152

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e77decfb1e9
[wpt PR 13761] - [css-properties-values-api] Proper computed value for <color>., a=testonly

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8e77decfb1e9