1502913 - Wrong label/accesskey is used in Options > Compose > General for entity Size

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

Under Options > Compose > General the entities size.label and size.accesskey are used and they should be read from mail/chrome/messenger/preferences/compose.dtd.
They are read from mail/chrome/messenger/preferences/display.dtd however, because both files use the same entity names and both files are included in mail/components/preferences/aboutPreferences.xul:

https://dxr.mozilla.org/comm-central/source/comm/mail/components/preferences/aboutPreferences.xul#16

https://dxr.mozilla.org/comm-central/source/comm/mail/components/preferences/doctype.inc#12-15

This poses a problem for localization where there's a difference between both labels or accesskeys.

Comment 1

[Onno Ekker [:nONoNonO UTC+1]]

The "offending" lines are:

https://dxr.mozilla.org/comm-central/source/comm/mail/locales/en-US/chrome/messenger/preferences/display.dtd?q=file%3Adisplay.dtd&redirect_type=single#15-16
<!ENTITY size.label                       "Size:">
<!ENTITY size.accesskey                   "z">
https://dxr.mozilla.org/comm-central/source/comm/mail/locales/en-US/chrome/messenger/preferences/compose.dtd#21-22
<!ENTITY size.label                           "Size:">
<!ENTITY size.accesskey                       "z">

I suppose one pair of entities should be renamed, e.g. in compose.dtd rename them to fontSize.label and fontSize.accesskey (or htmlSize.label and htmlSize.accesskey), but if you rename them to htmlSize, it would probably make sense to also rename font.label and font.accesskey tp htmlFont.label and htmlFont.accesskey.

Either way: if you rename one of these entities, you should check with l10n if it is possible and wise to rename those entities for all locales automatically. At the moment for Dutch locale, there is a difference in font.accesskey in both files, but the wrong accesskey is shown in Options > Compose > General.

Comment 2

[Jorg K (CEST = GMT+2)]

Richard, can you take care of this.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1502913-prefs-label.patch

Like this?

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9021586 [details] [diff] [review]
1502913-prefs-label.patch

I think so, but let's ask the reporter.

Comment 5

[Onno Ekker [:nONoNonO UTC+1]]

Yes, that should do the trick... New entities require new translations, so this fix can only make it in next release (tb68?).
There's no secure way to do this sooner, because with this change the for all locales that have different labels/accesskeys in both files, now the specified labels/accesskeys are used and they can conflict with other accesskeys.
(For Dutch however the current accesskey is conflicting, but I guess we have to wait a bit...)

Comment 6

[Richard Marti (:Paenglab)]

On TB 60 there should be no problem as the prefs in tab aren't the default and not many know about it.

Comment 7

[Onno Ekker [:nONoNonO UTC+1]]

Ah great! I hadn't noticed that the problem only occurred with inContent prefs and I forgot I toggled that option on sometime...

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0216225d5fba
Rename compose size.label/size.accesskey to distinguish from display in prefs. r=jorgk