Add Telemetry probes for language settings

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P1
normal
RESOLVED FIXED
9 months ago
6 months ago

People

(Reporter: mstriemer, Assigned: mstriemer)

Tracking

(Blocks 1 bug)

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #1486507 +++

We'd like to collect more specific data on the user's language settings so that we can discover mismatches between OS language and browser language to determine usage of the language tools within Firefox.

This document collects the initial thoughts and feedback about the kind of telemetry data we'd like to collect
https://docs.google.com/document/d/1Ad_QXuyy62WE1KX5oLUAOH0K7FW6IXX3HrLqaACPYlc
Posted file data-review.txt (obsolete) —
There's a similar data review request in bug 1486507, if it's easier to combine them let me know and I'll do that.
Attachment #9021600 - Flags: review?(chutten)
Attachment #9021600 - Attachment is obsolete: true
Attachment #9021600 - Flags: review?(chutten)
Posted file data-review.txt
Combined with bug 1500147.
Attachment #9021605 - Flags: review?(chutten)
Comment on attachment 9021605 [details]
data-review.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :flod will monitor this collection over time.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on, all channels.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

Only locale names by the looks of things.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

N/a, permanent collection.

---
Result: datareview+
Attachment #9021605 - Flags: review?(chutten) → review+
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0be6d91b302
Record telemetry environment data about locales r=chutten

Backed out changeset a0be6d91b302 (Bug 1502921) for toolkit/components/telemetry/tests/unit/*(eg. test_SubsessionChaining.js, test_TelemetryController.js) failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=25af8129d9f2c71b724398b64407cbde3215f407&searchStr=android%2C4.3%2Capi16%2B%2Copt%2Cxpcshell%2Ctests%2Ctest-android-em-4.3-arm7-api-16%2Fopt-xpcshell-8%2Cx%28x8%29&fromchange=a3092a304863b66c609e77e8b4aefb271b527eb8&selectedJob=222578637

Backout link: https://hg.mozilla.org/integration/autoland/rev/5ba4abc2b49cd15790569fb4f087cb533167f03d

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222578637&repo=autoland&lineNumber=2039

[task 2019-01-17T23:24:19.989Z] 23:24:19 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_MigratePendingPings.js
[task 2019-01-17T23:24:27.717Z] 23:24:27 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_MigratePendingPings.js | took 7727ms
[task 2019-01-17T23:24:28.342Z] 23:24:28 INFO - adb Ignoring attempt to chmod external storage
[task 2019-01-17T23:24:28.760Z] 23:24:28 INFO - adb Ignoring attempt to chmod external storage
[task 2019-01-17T23:24:29.073Z] 23:24:29 INFO - adb Ignoring attempt to chmod external storage
[task 2019-01-17T23:24:29.178Z] 23:24:29 INFO - adb Ignoring attempt to chmod external storage
[task 2019-01-17T23:24:29.179Z] 23:24:29 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_TelemetryHistograms.js
[task 2019-01-17T23:24:38.021Z] 23:24:38 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_TelemetryHistograms.js | took 8841ms
[task 2019-01-17T23:24:38.647Z] 23:24:38 INFO - adb Ignoring attempt to chmod external storage
[task 2019-01-17T23:24:39.065Z] 23:24:39 INFO - adb Ignoring attempt to chmod external storage
[task 2019-01-17T23:24:39.378Z] 23:24:39 INFO - adb Ignoring attempt to chmod external storage
[task 2019-01-17T23:24:39.483Z] 23:24:39 INFO - adb Ignoring attempt to chmod external storage
[task 2019-01-17T23:24:39.485Z] 23:24:39 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js
[task 2019-01-17T23:24:48.316Z] 23:24:48 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | xpcshell return code: 0
[task 2019-01-17T23:24:48.316Z] 23:24:48 INFO - TEST-INFO took 8830ms
[task 2019-01-17T23:24:48.317Z] 23:24:48 INFO - >>>>>>>
[task 2019-01-17T23:24:48.317Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | xpcw: cd /sdcard/tests/xpc/toolkit/components/telemetry/tests/unit
[task 2019-01-17T23:24:48.319Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | xpcw: xpcshell -r /sdcard/tests/xpc/c/httpd.manifest --greomni /data/local/xpcb/target.apk -m -s -e const _HEAD_JS_PATH = "/sdcard/tests/xpc/head.js"; -e const _MOZINFO_JS_PATH = "/sdcard/tests/xpc/p/mozinfo.json"; -e const _PREFS_FILE = "/sdcard/tests/xpc/user.js"; -e const _TESTING_MODULES_DIR = "/sdcard/tests/xpc/m"; -f /sdcard/tests/xpc/head.js -e const _HEAD_FILES = ["/sdcard/tests/xpc/toolkit/components/telemetry/tests/unit/head.js"]; -e const _JSDEBUGGER_PORT = 0; -e const _TEST_FILE = ["test_SubsessionChaining.js"]; -e const _TEST_NAME = "toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js"; -e _execute_test(); quit(0);
[task 2019-01-17T23:24:48.319Z] 23:24:48 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-01-17T23:24:48.319Z] 23:24:48 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-01-17T23:24:48.320Z] 23:24:48 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-01-17T23:24:48.320Z] 23:24:48 INFO - running event loop
[task 2019-01-17T23:24:48.321Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | Starting test_setup
[task 2019-01-17T23:24:48.321Z] 23:24:48 INFO - (xpcshell/head.js) | test test_setup pending (2)
[task 2019-01-17T23:24:48.322Z] 23:24:48 INFO - (xpcshell/head.js) | test pending (3)
[task 2019-01-17T23:24:48.323Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | JavaScript strict warning: resource://testing-common/AddonTestUtils.jsm, line 313: ReferenceError: reference to undefined property "testScope"
[task 2019-01-17T23:24:48.323Z] 23:24:48 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "testScope"" {file: "resource://testing-common/AddonTestUtils.jsm" line: 313}]"
[task 2019-01-17T23:24:48.323Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483333 addons.manager DEBUG Application has been upgraded
[task 2019-01-17T23:24:48.324Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483349 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]
[task 2019-01-17T23:24:48.324Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483413 addons.manager DEBUG Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"]
[task 2019-01-17T23:24:48.325Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483532 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm
[task 2019-01-17T23:24:48.325Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483548 addons.manager DEBUG Starting provider: XPIProvider
[task 2019-01-17T23:24:48.325Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483558 addons.xpi DEBUG startup
[task 2019-01-17T23:24:48.326Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483591 addons.xpi INFO SystemAddonLocation directory is missing
[task 2019-01-17T23:24:48.326Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483799 addons.xpi INFO Removing all system add-on upgrades.
[task 2019-01-17T23:24:48.327Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483821 addons.xpi DEBUG checkForChanges
[task 2019-01-17T23:24:48.328Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483827 addons.xpi DEBUG Loaded add-on state: ${}
[task 2019-01-17T23:24:48.328Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483847 addons.xpi DEBUG New add-on tel-system-xpi@tests.mozilla.org in app-system-defaults
[task 2019-01-17T23:24:48.329Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | JavaScript strict warning: resource://gre/modules/addons/XPIProvider.jsm, line 545: ReferenceError: reference to undefined property "version"
[task 2019-01-17T23:24:48.329Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | JavaScript strict warning: resource://gre/modules/addons/XPIProvider.jsm, line 442: ReferenceError: reference to undefined property "currentModifiedTime"
[task 2019-01-17T23:24:48.330Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483889 addons.xpi WARN Can't get modified time of /sdcard/tests/xpc/p/sysfeatures/app0/tel-system-xpi@tests.mozilla.org.xpi
[task 2019-01-17T23:24:48.330Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767483911 addons.xpi DEBUG scanForChanges changed: true, state: {}
[task 2019-01-17T23:24:48.331Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | 1547767484067 addons.xpi-utils DEBUG Error: Synchronously loading the add-ons database(resource://gre/modules/addons/XPIDatabase.jsm:1286:15) JS Stack trace: syncLoadDB@XPIDatabase.jsm:1286:15
[task 2019-01-17T23:24:48.331Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | checkForChanges@XPIProvider.jsm:2568:9
[task 2019-01-17T23:24:48.332Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | startup@XPIProvider.jsm:2148:25
[task 2019-01-17T23:24:48.332Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | callProvider@AddonManager.jsm:203:12
[task 2019-01-17T23:24:48.332Z] 23:24:48 INFO - toolkit/components/telemetry/tests/unit/test_SubsessionChaining.js | _startProvider@AddonManager.jsm:652:5

Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de6426e0f491
Record telemetry environment data about locales r=chutten
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Flags: needinfo?(mstriemer)
You need to log in before you can comment on or make changes to this bug.