1502950 - Error pages broken in custom tabs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Custom Tabs, defect)

Description

[Dylan Roeh (:droeh) (he/him)]

Error pages are currently broken in custom tabs, some quick testing makes it look like bug 1480095 or bug 1451476 is the culprit.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Fix custom tabs error pages

This fixes some regressions from bug 1480095 to get custom tabs error pages working properly again.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 9020909 [details] [diff] [review]
Fix custom tabs error pages

Review of attachment 9020909 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/geckoview/GeckoViewNavigationContent.js
@@ +14,5 @@
>  // Implements nsILoadURIDelegate.
>  class GeckoViewNavigationContent extends GeckoViewContentModule {
>    onInit() {
>      docShell.loadURIDelegate = this;
> +    addEventListener("DOMContentLoaded", this);

It would be nice if we only did this for Fennec, since it's not useful otherwise.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Attachment: Fix custom tabs error pages

Updated per snorp's comment to only listen to DOMContentLoaded in Fennec, now depends on bug 1503658. Carrying over snorp's r+.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be98a5ed931b
Fix error pages in custom tabs. r=snorp

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/be98a5ed931b