Remove livemarks code from toolkit

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P1
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: mak, Assigned: standard8)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

We removed all the frontend code, now we're left with the toolkit code.
We should understand how to coordinate with suite, we can slightly delay the livemarks code removal, but anyway we want to remove item annotations because they are source of UI jank, so we can't just keep the livemarks code around, it would break regardless when we remove item annotations code.

Jorg, do you have any idea who we should contact, or how we may handle this?
Flags: needinfo?(jorgk)
Note, the change is likely to not break the world, basically livemarks will de-facto become empty folders (though, we can't predict exceptions thrown by the frontend code if it tries to call into no more existing APIs).

Updated

6 months ago
Blocks: 1447707

Comment 2

6 months ago
Note that this also blocks removing the SAX XML reader which, as far as we know, has no other in-tree consumers.

TBH, I think it should be fairly straightforward for TB/XM to essentially copy/paste ("move") the toolkit code here and start being responsible for it themselves. Of course, what'll happen when the places support for annotations is removed, I dunno - at least for TB I'd expect it not to care, but suite is probably different.

Comment 3

6 months ago
(In reply to Marco Bonardo [::mak] from comment #0)
> Jorg, do you have any idea who we should contact, or how we may handle this?
Good question. I work for Thunderbird, and I/we occasionally help out with SeaMonkey stuff. As far as I know, SM trunk isn't a good shape, there have been too many Mozilla platform changes they haven't followed yet, like removal of overlays or bindings.

The guy to talk to is Frank-Rainer.
Flags: needinfo?(jorgk) → needinfo?(frgrahl)
suite builds but is broken. Just remove it. If/when we ever catch up we will fix it.
Flags: needinfo?(frgrahl)
I would like to point out this is about Places livemarks code, not the toolkit/components/feeds component, that would require a separate bug, and I guess that's what blocks removing the SAX XML reader?
Flags: needinfo?(gijskruitbosch+bugs)

Updated

6 months ago
See Also: → 1503214

Updated

6 months ago
No longer blocks: 1447707

Comment 6

6 months ago
(In reply to Marco Bonardo [::mak] from comment #5)
> I would like to point out this is about Places livemarks code, not the
> toolkit/components/feeds component, that would require a separate bug, and I
> guess that's what blocks removing the SAX XML reader?

OK, I've split this off, though I'm not sure if we can proceed with that without first removing the places code that calls into the feed processor...
Flags: needinfo?(gijskruitbosch+bugs)
that's fine, we'll try to remove the places code in the next few weeks.

Updated

6 months ago
Blocks: 1503214
See Also: 1503214
(Assignee)

Updated

5 months ago
Assignee: nobody → standard8
Priority: -- → P1
(Assignee)

Updated

5 months ago
Blocks: 1507809

Comment 9

5 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2654a2729e9
Remove livemarks code from toolkit. r=mak

Comment 10

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b2654a2729e9
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65

Comment 12

5 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a0668a318ffa
Port bug 1502954 - Remove nsLivemarkService.js from package manifests. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.