Closed Bug 1502955 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13763 - [css-properties-values-api] Validate generate_property argument.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13763 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13763
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  [css-properties-values-api] Validate generate_property argument.
>  
>  This prevents silently dropping invalid arguments. For example, the
>  following currently generates a non-inherited property:
>  
>    let name = generate_property(syntax: '\<length>', inherited: true);
>  
>  This is because 'inherited' is not an option for CSS.registerProperty (the
>  actual option is 'inherits').
>  
>  With this change, an exception is thrown if unknown options are provided.
>  
>  R=futhark@chromium.org
>  
>  Bug: 641877
>  Change-Id: I7b639651c331aa705416db95a3de751353648031
>  Reviewed-on: https://chromium-review.googlesource.com/1304522
>  WPT-Export-Revision: 872d26676c59d1bc8ab871a340922e2c993754ab
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 2 tests and 17 subtests
OK     : 2
PASS   : 1
FAIL   : 16

New tests that have failures or other problems:
/css/css-properties-values-api/registered-property-computation.html
    <length-percentage> values are computed correctly for divWithFontSizeInherited: FAIL
    <length-percentage> values are computed correctly for divWithFontSizeSet: FAIL
    <length-percentage># values are computed correctly for divWithFontSizeInherited: FAIL
    <length-percentage># values are computed correctly for divWithFontSizeSet: FAIL
    <length-percentage>+ values are computed correctly for divWithFontSizeInherited: FAIL
    <length-percentage>+ values are computed correctly for divWithFontSizeSet: FAIL
    <length> values are computed correctly for divWithFontSizeInherited: FAIL
    <length> values are computed correctly for divWithFontSizeSet: FAIL
    <length># values are computed correctly for divWithFontSizeInherited: FAIL
    <length># values are computed correctly for divWithFontSizeSet: FAIL
    <length>+ values are computed correctly for divWithFontSizeInherited: FAIL
    <length>+ values are computed correctly for divWithFontSizeSet: FAIL
    <transform-function> values are computed correctly for divWithFontSizeInherited: FAIL
    <transform-function> values are computed correctly for divWithFontSizeSet: FAIL
/css/css-properties-values-api/self-utils.html
    Default initial values of generated properties are valid (self-test).: FAIL
    Generated properties respect inherits flag: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60774ca43509
[wpt PR 13763] - [css-properties-values-api] Validate generate_property argument., a=testonly
https://hg.mozilla.org/mozilla-central/rev/60774ca43509
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.