1503001 - [traceback] AttributeError: 'unicode' object has no attribute 'get' in /monitoring/crontabber

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

https://sentry.prod.mozaws.net/operations/socorro-new-prod/issues/4893551/

"""
AttributeError: 'unicode' object has no attribute 'get'
  File "django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)
  File "django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/utils.py", line 56, in wrapper
    response = f(request, *args, **kw)
  File "crashstats/monitoring/views.py", line 27, in crontabber_status
    all_apps = api.get()['state']
  File "crashstats/crashstats/models.py", line 1007, in get
    'type': last_error.get('type', 'Unknown')
"""

This just started happening after we pushed out changes to crontabber to prod. It's entirely possible it's because the table is empty and once we get stuff in the table, it'll go away.

Even so, it's worth fixing it. This bug covers that.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

pingdom uses this endpoint, so it paged ops.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4673: fix bug 1503001: fix handling of last_error

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/795b54c5b708bb6dad77df240cd6d667c42f61ae
fix bug 1503001: fix handling of last_error

https://github.com/mozilla-services/socorro/commit/2be8ab645a99f65e13511118d66c1663d75146f0
Merge pull request #4673 from willkg/1503001-last-error-fix

fix bug 1503001: fix handling of last_error