Closed Bug 1503012 Opened Last year Closed 11 months ago

ReadableStream shell tests

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

We should have at least a few jit-tests that exercise streams, as a smoke test if nothing else.
Summary: ReadableStream jit-tests → ReadableStream shell tests
Blocks: streams-meta
Well, bad news -- the tinderbox job that runs jit-tests does not get a full source tree, so the load("../../../../testing/web-platform/blahblah") trick, which deserved to go down in flames, did in fact go down in flames.

Not sure what to do instead. I guess I'll try copying whole files and checking them in. Couple of bash scripts. Situation normal.
Assignee: nobody → jorendorff
Priority: -- → P1
Blocks: streams-ship
This is an egregious hack. The web-platform-tests were not meant to run in the shell.

The eight tests that are included are the ones that we pass with flying colors.
In most of the others, we still have a failure or two.

Depends on D11532
Keywords: leave-open
Attachment #9024129 - Attachment description: Bug 1503012 - Part 1: Some basic ReadableStream tests that run in the shell. r?tcampbell → Bug 1503012 - Part 1: Some basic ReadableStream tests that run in the shell. r?arai
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96d08f7859d1
Part 1: Some basic ReadableStream tests that run in the shell. r=arai
Today I got help from gps, dhouse, bcrisan, bc, and tomprince on this.

Tom pointed me at <https://searchfox.org/mozilla-central/source/build/gen_test_packages_manifest.py> which seems very likely to be the right direction.
Hey, that worked, somewhat:

https://tools.taskcluster.net/groups/YC8WGn_kTnyNKyWEHqPKhw/tasks/fNbiZlXfTSifJH3BFar92w/runs/0/logs/public%2Flogs%2Flive_backing.log#L235

I think I can get this to pass. It's not pretty, and I shouldn't have spent all this time on it. But now that I know how to do it, it seems better than copying the files.
Attachment #9024130 - Attachment description: Bug 1503012 - Part 2: Shim some web-platform-tests for streams into the jit-tests. r?tcampbell → Bug 1503012 - Part 2: Shim some web-platform-tests for streams into the jit-tests. r?arai
Keywords: leave-open
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2a0ae5e5115
Part 2: Shim some web-platform-tests for streams into the jit-tests. r=arai,chmanchester
Two real bugs, one in this patch (I wasn't updating make-source-package.sh, so SM(pkg) failed) and one in bug 1512050 (just a thinko in one of the test files, easily fixed). I'll reland this weekend.
Flags: needinfo?(jorendorff)
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10e651a2adff
Part 2: Shim some web-platform-tests for streams into the jit-tests. r=arai,chmanchester,jimb
https://hg.mozilla.org/mozilla-central/rev/10e651a2adff
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Unfortunately the approach here is problematic. By hardcoding the names of the tests we break if upstream moves or otherwise rearranges the tests. This has just happened with the pending wpt update. Ms2ger did some work to make running the WASM tests in a shell possible; I wonder if we could reuse that code here rather than doing something novel. As it is I either need to manually update the list of tests (which will allow the new update to land, but isn't anything like a long-term solution) or back this out.
Flags: needinfo?(jorendorff)
<jgraham> jorendorff: I have a patch to fixup the current situation
<jgraham> jorendorff: In the long term, Ms2ger has something that works for
  jstest.py to run the tests in the shell using metadata in the tests and
  without a wrapper
<jgraham> He thinks it should be possible to reuse in this case, so I think
  that's the right thing to do

I will be so happy if we can back out this terrible patch :)
Depends on: 1513570
I am backing this out in bug 1513570. \o/
Flags: needinfo?(jorendorff)
You need to log in before you can comment on or make changes to this bug.