Closed
Bug 1503055
Opened 6 years ago
Closed 6 years ago
Avoid deadlocking when rewinding to avoid a different deadlock.
Categories
(Core Graveyard :: Web Replay, enhancement)
Core Graveyard
Web Replay
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
973 bytes,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
The attached patch fixes an issue in part 3 of bug 1500805, where we rewind to avoid deadlocking but while doing so are holding a spinlock which other threads might need in order to create or destroy the information associated with each platform mutex. In order to rewind we need all other threads to enter a specific idle state, and to reach such a state they might need to take this spinlock, so we end up deadlocking. The fix releases the spinlock before starting the rewind.
Attachment #9020956 -
Flags: review?(continuation)
|
||
Updated•6 years ago
|
Attachment #9020956 -
Flags: review?(continuation) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/62a1d3756cc2 Avoid deadlocking when rewinding to avoid a different deadlock, r=mccr8.
|
||
Comment 2•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/62a1d3756cc2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•