Closed Bug 1503055 Opened Last year Closed Last year

Avoid deadlocking when rewinding to avoid a different deadlock.

Categories

(Core :: Web Replay, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The attached patch fixes an issue in part 3 of bug 1500805, where we rewind to avoid deadlocking but while doing so are holding a spinlock which other threads might need in order to create or destroy the information associated with each platform mutex.  In order to rewind we need all other threads to enter a specific idle state, and to reach such a state they might need to take this spinlock, so we end up deadlocking.  The fix releases the spinlock before starting the rewind.
Attachment #9020956 - Flags: review?(continuation)
Attachment #9020956 - Flags: review?(continuation) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62a1d3756cc2
Avoid deadlocking when rewinding to avoid a different deadlock, r=mccr8.
https://hg.mozilla.org/mozilla-central/rev/62a1d3756cc2
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.