1503077 - Disable spectre mitigations by default on mips.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[yuyin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0 Safari/605.1.15

Steps to reproduce:

build firefox or js and run it.




Actual results:

it crash because of unimplemented function.


Expected results:

run successfully

Comment 1

[yuyin]

see also 1442217 and 1468277 . So I just want to disable it by default on mips.

see 1425986, So I use JS_CODEGEN_MIPS32 and JS_CODEGEN_MIPS64 as it is on mips platform, is that ok?

Comment 2

[yuyin]

Attachment: 0001-Disable-spectre-mitigations-by-default-on-mips-64.patch

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 9020982 [details] [diff] [review]
0001-Disable-spectre-mitigations-by-default-on-mips-64.patch

Review of attachment 9020982 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: js/src/jit/JitOptions.cpp
@@ +234,4 @@
>          }
>      }
>  
> +#ifdef __mips__

This should also be:

#if defined(JS_CODEGEN_MIPS32) || defined(JS_CODEGEN_MIPS64)

Comment 4

[yuyin]

Attachment: 0001-Disable-spectre-mitigations-by-default-on-mips-64.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/994d18f1e30d
Disable spectre mitigations by default on mips(64). r=jandem

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/994d18f1e30d