Closed
Bug 1503078
Opened 6 years ago
Closed 6 years ago
Simplify nsINode event handler implementations
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
3.17 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Right now we have per-atom getters/setters defined on nsINode that are out-of-line functions and do some getting of event listener managers, etc. We can change them to inline functions that just pass the atom to the single out-of-line function that does the right thing on EventTarget.
|
Assignee | |
Comment 1•6 years ago
|
||
The old setup made more sense when these were in fact NS_IMETHODs.
Attachment #9020984 -
Flags: review?(bugs)
|
||
Updated•6 years ago
|
Priority: -- → P2
|
||
Updated•6 years ago
|
Attachment #9020984 -
Flags: review?(bugs) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/64c0da939880 Simplify the Node event handler macros. r=smaug
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/64c0da939880
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•