Closed Bug 1503104 Opened 1 year ago Closed 1 year ago

Add a CompileLazyFunction overload that supports UTF-8

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

Attachments

(1 file)

No description provided.
Attached patch PatchSplinter Review
This is necessary for lazy functions to work in UTF-8-parsed scripts.

Probably there are parts of CreateLazyFunction that could/should be extracted into the callers, like the creation of StandaloneFunctionInfo -- or into callers of CompileLazyFunction.  This is Least Effort needed to get to UTF-8 parsing working tho.
Attachment #9021035 - Flags: review?(tcampbell)
Blocks: 1503105
Comment on attachment 9021035 [details] [diff] [review]
Patch

Review of attachment 9021035 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/BytecodeCompiler.cpp
@@ +926,5 @@
>  };
>  
> +template<typename Unit>
> +static bool
> +CreateLazyFunction(JSContext* cx, Handle<LazyScript*> lazy, const Unit* units, size_t length)

-> CompileLazyFunctionImpl
Attachment #9021035 - Flags: review?(tcampbell) → review+
Priority: -- → P2
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d759d8052e76
Add a CompileLazyFunction overload that supports UTF-8.  r=tcampbell
https://hg.mozilla.org/mozilla-central/rev/d759d8052e76
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.