1503124 - Update rules to serve Widevine 4.10.1196.0 to Desktop (Windows, Mac, and Linux)

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, enhancement)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Following on from Bug 1486482, which saw us update to a new Widevine version (4.10.1146.0), the media team are looking to follow up with a minor version bump. This will address an issue we're seeing with crashes on older Mac hardware.

All the interface work to accommodate this change should have landed in Firefox 64, so this is a matter of updating the rules and testing to make sure no issues occur -- this shouldn't depend on any further code changes.

Before rolling out to nightly I would like manually test this myself via nightly-test. Could we please update the nightly test rules to serve the new CDM for testing? The details for the CDM are:

Linux 32bit:
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1196.0-linux-ia32.zip
SHA512: 08b9644e1449ebb1de300e0ac9a4b45f5fa8a7ea8ecbab88fdf0ad8e713f0891b6285c0740e9e3f510a2a0248b193271f1533252ca4e9fe701445fcf0526dbe0
file size: 3243268 bytes

Linux 64bit:
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1196.0-linux-x64.zip
SHA512: 98fb97ec6c31277a9d56ae120dcdb99e8e13f8b0a06b95a4668a3e868931dff571caea584359ee9fc6a31c84549f3dbabfcb33ba7a610af68e0a554ea13c9c5f
file size: 3086102 bytes

For reference Bug 1493255 tracks the previous rule change.

MacOS:
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1196.0-mac-x64.zip
SHA512: 0a92f9743e151a78ae89d07f4e9c0a6bd5e2192b236a1ac5c1e019e570703f67c68b79f469ed3a94020e114f46dc3774d41b8a1df26a6b3a3bb000094d74a06f
file size: 3529196 bytes

Win 7/8/10 32bit:
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1196.0-win-ia32.zip
SHA512: ab5c1cb0368974c805b2ea931adf3bba2619c8d6b6b29ec7ad7d80a9d051e8943ba839940866761fe8b321b0a84c5157479657a2c26e1c1aef31c0e6719ef9cf
file size: 3931391 bytes

Win 7/8/10 64bit:
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1196.0-win-x64.zip
SHA512: 7e9f36add38c7094d199212975abdf3b48fa98b4c90d1de40531bac0516925144812e81ea94f250a5b729c7b0c7d340cceca194d5796b7b314f9402b02087858
file size: 3786874 bytes

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

The

> For reference Bug 1493255 tracks the previous rule change.

line was intended to follow the CDM information, and was not interjected into the middle to suggest any special relation to a specific platform.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Aki, could you help with the rule adjustment to get these to nightly-test so testing can begin?

Also confirming that the comment #0 files and hashes are still correct, and were not impacted by Google's recent modification of some of the other CDM downloads that broke our hashes.

Comment 3

[Aki Sasaki (not active)]

Simon, Callek, as releaseduty, are you up for looking at this?
Johan and Jordan documented the process here https://github.com/mozilla-releng/releasewarrior-2.0/blob/master/docs/misc-operations/widevine-updates.md .

Comment 4

[Jordan Lund (:jlund)]

Taking this off aki's plate.

Widevine requests have been handed off to releaseduty now. Releaseduty should monitor "Release Requests" component but if it's missed and not triaged, please ping/needinfo the people providing duty coverage (names are in #releaseduty channel topic).

@callek, @sfraser - could you have a look at this request when time permits? Should be similar to last version update. Myself or aki can assist.


docs: https://github.com/mozilla-releng/releasewarrior-2.0/blob/master/docs/misc-operations/widevine-updates.md

previous bug: Bug 1475260 - Update Widevine CDM to version 1.4.9.1088 (Windows, Mac, and Linux)

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Thank you for the updated information, wasn't sure who to reach out to and was going off similar requests that had previously been handled.

Comment 6

[Simon Fraser [:sfraser] ⌚️GMT]

https://aus4-admin.mozilla.org/releases#Widevine-4.10.1196.0 now exists. I've scheduled a rule change for a few hours time, so there's an opportunity for it to be checked.

Comment 7

[Jordan Lund (:jlund)]

(In reply to Bryce Seager van Dyk (:bryce) from comment #5)
> Thank you for the updated information, wasn't sure who to reach out to and
> was going off similar requests that had previously been handled.

No worries, we don't have formal docs for making requests like this. Because of that, I think we as releng are happy to redirect when appropriate.

Comment 8

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I'm checking on the nightly-test channel and am seeing unexpected behaviour. I've verified I'm on the nightly-test channel via about:config. For Firefox 65 (current nightly) on Windwos I'm served the following CDMs:

Win64: 4.10.1146.0
Win32: 1.4.9.1088. Even were there issues with nightly test, I would have expected 4.10.1146.0. This also appears to be served on the nightly channel.

Simon, could you please take a look at the rules to make sure they're in order?

Clarifying the CDMs expected per version:
63 + ESR: 1.4.9.1088
64: 4.10.1146.0*
65: 4.10.1146.0
nightly-test: 4.10.1196.0

* There may have been some date rules due to when we landed code in central that were needed while on nightly, these can now be done away with.

Comment 9

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Looks like my continued recollection that nightlytest has a dash in it has bitten me again. `nightlytest` rather than `nightly-test` appears to be working correctly. Apologies for the confusion.

I've also rechecked the 32 bit builds, and appear to be getting the expected CDM. As such, please disregard my previous comment.

Comment 10

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I've smoke tested the new update without issue. Could we please update the nightly channel to serve 4.10.1196.0 to Linux, Mac, and Windows using the details from comment #0?

Comment 11

[Simon Fraser [:sfraser] ⌚️GMT]

I've scheduled the change in Balrog, for 11am GMT today

Comment 12

[Julien Cristau [:jcristau]]

The change seems to be set to ship this to all channels instead of just nightly?

Comment 13

[Julien Cristau [:jcristau]]

Clarified on irc and fixed; this is live on nightly 65.

Comment 14

[Julien Cristau [:jcristau]]

What's the status and plan on this?  Is it going to ride the trains to 65, with 64 staying on 4.10.1146.0?  Or are we rolling back 64 to 1.4.9.1088?  Or something else?

Comment 15

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

We'd like to have 4.10.1196.0 go to 64 as well. The corresponding fallback downloader patch landed in nightly recently (Bug 1507389) and I wanted a little time for it to bake before requesting the uplift of that work and the rules changes.

I was thinking that we could update the rules to serve this update to 64 next week, does that sound suitable? The update requires no code changes in central (though we will update the fallback downloader so the versions match) and should not change any functionality aside from addressing the Mac crash discussed in bug 1495751.

Comment 16

[Julien Cristau [:jcristau]]

Next week is the last week before we build 64.0 release candidates, so we don't have a whole lot of time to shake things out there.  Probably best not to the rules update on a Friday though, so early next week should work.

Comment 17

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Simon, could we update the rules to also have this update given to beta (Firefox 64)?

For clarity, we'd no longer be serving 4.10.1146.0 as it has a crash issue, and I believe the rules would be something like this for our currently supported Firefoxes:

- CDM 4.10.1196.0 goes to version >=64.0a1
  - I think we can safely remove the rule that currently has ID 842 as part of this, that rule was used to stop earlier builds of 64, when it was on the nightly cycle, from receiving a CDM that such builds didn't have code for. However, now that 64 is in beta, we shouldn't have any such issues.
- CDM 1.4.9.1088 goes to 63, ESR60 (which existing rules already take care of)

Comment 18

[Justin Wood (:Callek)]

Attachment: Screenshot_2018-11-27 Rules - Balrog Admin.png

This should be live as soon as relman signs off on it, the attachment is the diff of changes being made (incase we need to revert, seeing this makes it slightly easier).

Comment 19

[Julien Cristau [:jcristau]]

This is now live.

Comment 20

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I've done a quick smoke test to confirm CDMs are being served as expected to our releases and beta is happy with the new CDM: everything appears to be working well. Thanks all!