1503195 - Mention deadline for build_metrics regressions

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement)

Description

[Ionuț Goldan [:igoldan]]

The templated message for build_metrics regressions misses the text:

"*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***"

It must be added to avoid developer confusion like it happened here [1].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1501178#c1

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4210

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

is this something we want to do?  I don't think backing out build related changes is realistic- please confirm with the build tools team this is desirable?

Comment 3

[Ionuț Goldan [:igoldan]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #2)
> is this something we want to do?  I don't think backing out build related
> changes is realistic- please confirm with the build tools team this is
> desirable?

I thought this procedure applies to all our tests.

:kmoir do you agree on allowing us Perf sheriffs to backout build related changes that caused regressions, but for which the authors didn't respond within 3 business days?

Comment 4

[William Lachance (:wlach)]

IIRC we agreed a few years ago not to back out build_metrics regressions, we would just notify who was responsible for them that they occurred. This was probably never written down...

Comment 5

[Kim Moir [:kmoir] ET]

I brought up this issue in our team meeting today and they agreed that having it at the same level as the others (3 days) is reasonable as long as they are notified.

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bfd784e0fbb68d3a1fba44f287dedeaa95db1ace
Bug 1503195 - Mention deadline for build_metrics regressions (#4210)