Closed
Bug 1503205
Opened 6 years ago
Closed 6 years ago
browser_firstPartyIsolation.js should do a better job of waiting for windows and cleaning up after itself so it passes with --verify
Categories
(Firefox :: General, defect, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
There are a few issues with this test: - it relies on cookies set with a Set-Cookie header from a js file. It clears the cookie service when the test finishes. If you run the test with --verify, the test next fails because the js files are cached and aren't re-fetched, so no cookies are set at all. Clearing the cache in the cleanup function fixes this. - there are a number of places where it waits for loads of URLs in new windows in a way that races with those new windows opening, which breaks the test.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7331875fe4c9522d6975f855854996f06b652db0
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/678fecfe0bb1 make browser_firstPartyIsolation.js more reliable, r=johannh
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/678fecfe0bb1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•