1503205 - browser_firstPartyIsolation.js should do a better job of waiting for windows and cleaning up after itself so it passes with --verify

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[:Gijs (he/him)]

There are a few issues with this test:

- it relies on cookies set with a Set-Cookie header from a js file. It clears the cookie service when the test finishes. If you run the test with --verify, the test next fails because the js files are cached and aren't re-fetched, so no cookies are set at all. Clearing the cache in the cleanup function fixes this.
- there are a number of places where it waits for loads of URLs in new windows in a way that races with those new windows opening, which breaks the test.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1503205 - make browser_firstPartyIsolation.js more reliable, r?johannh

Comment 2

[:Gijs (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7331875fe4c9522d6975f855854996f06b652db0

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/678fecfe0bb1
make browser_firstPartyIsolation.js more reliable, r=johannh

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/678fecfe0bb1