browser_firstPartyIsolation.js should do a better job of waiting for windows and cleaning up after itself so it passes with --verify

RESOLVED FIXED in Firefox 65

Status

()

defect
P3
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks 1 bug)

Trunk
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
There are a few issues with this test:

- it relies on cookies set with a Set-Cookie header from a js file. It clears the cookie service when the test finishes. If you run the test with --verify, the test next fails because the js files are cached and aren't re-fetched, so no cookies are set at all. Clearing the cache in the cleanup function fixes this.
- there are a number of places where it waits for loads of URLs in new windows in a way that races with those new windows opening, which breaks the test.

Comment 3

6 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/678fecfe0bb1
make browser_firstPartyIsolation.js more reliable, r=johannh

Comment 4

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/678fecfe0bb1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.