Closed Bug 1503218 Opened 6 years ago Closed 6 years ago

No notifications for address cards created through drag-n-drop

Categories

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Product:
Thunderbird
Component:
Add-Ons: Extensions API
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird64 fixed, thunderbird65 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 65.0
Tracking Flags:
Tracking Status
thunderbird64 --- fixed
thunderbird65 --- fixed

People

(Reporter: neil, Assigned: darktrojan)

References

Details

Attachments

(1 file)

1503218-addrbook-drop-1.diff
1.33 KB, patch
mkmelin
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review 
The new WebExtensions API notifies you if a card was created through the "New Card" UI. But you can also "create" cards by dragging them between address books; in this case, a notification for the card being removed from the source address book is generated, but there is no notification for the card being added to the target address book.

I haven't tested dragging addresses to a mailing list in a different address book, which should probably generate a create, a delete, and a list member add.
Flags: needinfo?(geoff)
Thanks for pointing out where the notification was missing from Neil, I'm glad I didn't have to wade through that stuff again to find it.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Attachment #9021444 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9021444 [details] [diff] [review]
1503218-addrbook-drop-1.diff

Review of attachment 9021444 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin
Attachment #9021444 - Flags: review?(mkmelin+mozilla) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d7ee8a2c861b
Add notification for address cards created through drag-n-drop; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Attachment #9021444 - Flags: approval-comm-beta?
Attachment #9021444 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: