Closed Bug 1503227 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13780 - [css-properties-values-api] Test computed values individually.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13780 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13780
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  [css-properties-values-api] Test computed values individually.
>  
>   - Having large buckets of assertions in the same test is not great if
>     one of those assertions fail.
>   - Running all tests twice with and without inherited font size is not
>     relevant for a large amount of the tests.
>  
>  Therefore:
>  
>   - Use only one assertion per test, allowing fine-grained test
>     expectations.
>   - Only test inherited font-size for a few relevant cases.
>  
>  R=futhark@chromium.org
>  
>  Bug: 641877
>  Change-Id: I0a26dc29da4ca3be04f33b86bb063e48cb2f4c08
>  Reviewed-on: https://chromium-review.googlesource.com/1304520
>  WPT-Export-Revision: 056b3dc9216d7c388bd19be4d74b9c94f193ce2d
PR 13780 applied with additional changes from upstream: 979839c026d9a272a0c5c09097b92b74b00ff90e, 38bb114c431508bf122a9699869c7a72e4feb5b3, 0cc29e423fd0785b5f906a903d9010519595a4ac, 9082397e214eef1fd04e478e353cd0d19a64f040, 9d2432a20edd05076fa49f265adeeb64e78a3aba
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 55 subtests
OK     : 1
FAIL   : 55

New tests that have failures or other problems:
/css/css-properties-values-api/registered-property-computation.html
    * values are computed correctly [-50grad]: FAIL
    * values are computed correctly [50dpi]: FAIL
    * values are computed correctly [50s]: FAIL
    * values are computed correctly [tomato]: FAIL
    <angle> values are computed correctly [180deg]: FAIL
    <angle> values are computed correctly [400grad]: FAIL
    <angle> values are computed correctly [calc(360deg + 400grad)]: FAIL
    <color> values are computed correctly [#00000a]: FAIL
    <color> values are computed correctly [#000f00]: FAIL
    <color> values are computed correctly [#badbee33]: FAIL
    <color> values are computed correctly [#badbee]: FAIL
    <color> values are computed correctly [#ff0000]: FAIL
    <color> values are computed correctly [currentcolor]: FAIL
    <color> values are computed correctly [plum]: FAIL
    <color> values are computed correctly [tomato]: FAIL
    <integer> values are computed correctly [15]: FAIL
    <integer> values are computed correctly [calc(15 + 15)]: FAIL
    <integer> values are computed correctly [calc(2.4)]: FAIL
    <integer> values are computed correctly [calc(2.6 + 3.1)]: FAIL
    <integer> values are computed correctly [calc(2.6)]: FAIL
    <integer>+ values are computed correctly [15 calc(2.4) calc(2.6)]: FAIL
    <length-percentage> values are computed correctly [17em]: FAIL
    <length-percentage> values are computed correctly [18%]: FAIL
    <length-percentage> values are computed correctly [calc(19em - 2%)]: FAIL
    <length-percentage># values are computed correctly [3% , 10vmax  , 22px]: FAIL
    <length-percentage># values are computed correctly [calc(13% + 37px)]: FAIL
    <length-percentage># values are computed correctly [calc(50% + 1em), 4px]: FAIL
    <length-percentage>+ values are computed correctly [3% 10vmax 22px]: FAIL
    <length-percentage>+ values are computed correctly [calc(50% + 1em) 4px]: FAIL
    <length> values are computed correctly [12px]: FAIL
    <length> values are computed correctly [13vw]: FAIL
    <length> values are computed correctly [14em]: FAIL
    <length> values are computed correctly [15vmin]: FAIL
    <length> values are computed correctly [calc(16px - 7em + 10vh)]: FAIL
    <length> values are computed correctly when font-size is inherited [14em]: FAIL
    <length> values are computed correctly when font-size is inherited [calc(14em + 10px)]: FAIL
    <length> values computed are correctly via var()-reference: FAIL
    <length> values computed are correctly via var()-reference when font-size is inherited: FAIL
    <length># values are computed correctly [10px, 3em]: FAIL
    <length># values are computed correctly [4em ,9px]: FAIL
    <length># values are computed correctly [8em]: FAIL
    <length>+ values are computed correctly [10px 3em]: FAIL
    <length>+ values are computed correctly [4em 9px]: FAIL
    <resolution> values are computed correctly [1dppx]: FAIL
    <resolution> values are computed correctly [96dpi]: FAIL
    <resolution> values are computed correctly [calc(1dppx + 96dpi)]: FAIL
    <time> values are computed correctly [1000ms]: FAIL
    <time> values are computed correctly [1s]: FAIL
    <time> values are computed correctly [calc(1000ms + 1s)]: FAIL
    <transform-function> values are computed correctly [translateX(10em)]: FAIL
    <transform-function> values are computed correctly [translateX(2px)]: FAIL
    <transform-function> values are computed correctly [translateX(calc(11em + 10%))]: FAIL
    <transform-function>+ values are computed correctly [translateX(10%) scale(2)]: FAIL
    tomato | plum values are computed correctly [plum]: FAIL
    tomato | plum | <color> values are computed correctly [plum]: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bbebb2c6a03
[wpt PR 13780] - [css-properties-values-api] Test computed values individually., a=testonly
https://hg.mozilla.org/mozilla-central/rev/6bbebb2c6a03
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.