Closed
Bug 1503229
Opened 7 years ago
Closed 7 years ago
XCUITests: Tests do not compile after Code Quality patch landed
Categories
(Firefox for iOS :: Build & Test, defect, P3)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: isabel_rios, Assigned: isabel_rios)
Details
Attachments
(1 file)
This is the patch breaking the tests:
https://github.com/mozilla-mobile/firefox-ios/commit/dc8b0b9cc9a0db3174b08ebc0024b666c5e9534e
The error with this patch is:
Source control conflict marker in source file
You can find it here:
https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/DragAndDropTests.swift#L157
Looks like that conflict was not solved before merging.
It's nice to have help with the code in the test, really appreciated but please I would kindly suggest to run at least one XCUI test when so many changes are done affecting the test suites before merging to check that the tests work. That will help to prevent from having issues like this.
Until this is fixed there are not going to be automated tests running for master.
Thanks
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → irios.mozilla
Attachment #9021143 -
Flags: review?(npark)
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Updated•7 years ago
|
Attachment #9021143 -
Flags: review?(npark) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/dc72a02dafb31f8a11df573cde291772cc901be2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•