Closed Bug 1503238 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 13781 - [webdriver]: add checks for execute_script tests recognising promises

Categories

(Testing :: geckodriver, enhancement, P4)

Product:
Testing
Component:
geckodriver
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13781 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/13781 Details from upstream follow. christian-bromann <mail@christian-bromann.com> wrote: > [webdriver]: add checks for execute_script tests recognising promises > > I've been come across point 4, 5, 6 and 7 of the `[execute_script](https://w3c.github.io/webdriver/#execute-script)` recognising promises if returned as such and apparently Geckodriver does resolve a promise properly but don't handle it well if rejected or after timing out. > > This is my first stab at this and would love to get initial feedback as it seems that drivers behave differently/inconsistent here which can be either a bug in the driver or in the protocol definition. > > The result of the added tests in Geckodriver (v0.23.0) is: > > - test_promise_resolve: PASSING > - test_promise_reject: FAILING - responds with 200 instead of 500 > - test_promise_timeout: FAILING - responds with 200 instead of 500 > > With Chromedriver (v2.43) they all fail with status code 200 and `value: {}`.
Component: web-platform-tests → geckodriver
Ran 1 tests and 10 subtests OK : 1 PASS : 4 FAIL : 6 New tests that have failures or other problems: /webdriver/tests/execute_script/promise.py test_await_promise_resolve: FAIL test_promise_all_reject: FAIL test_promise_reject: FAIL test_promise_reject_delayed: FAIL test_promise_reject_timeout: FAIL test_promise_resolve_timeout: FAIL
James, what's the next step here? The upstream PR got merged, and I kinda would like to see those tests in our repository. Can you please trigger this stalled process?
Flags: needinfo?(james)
I'm doing it; the landings got super behind because an infra change blocked things. But we're catching up now.
Flags: needinfo?(james)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3956ac50444c [wpt PR 13781] - [webdriver]: add checks for execute_script tests recognising promises, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/81d9ddb8f2ef [wpt PR 13781] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/3956ac50444c https://hg.mozilla.org/mozilla-central/rev/81d9ddb8f2ef
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.