Closed Bug 1503288 Opened Last year Closed Last year

Change `url` to `args` to fix busted simplified onboarding actions

Categories

(Firefox :: Messaging System, defect, P1)

57 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 65
Iteration:
64.3 - Oct 12
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 + verified
firefox65 + verified

People

(Reporter: ursula, Assigned: ursula)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1496357 changed the action button parameters to look for `args`, but didn't change the OnboardingMessageProvider's parameters to be `args` instead of `url` for OPEN_URL therefore the onboarding actions are busted in 64 and 65 when Bug 1496428 landed. This will need to be uplifted to beta 64.

Github PR that created the bug: https://github.com/mozilla/activity-stream/commit/47f11743abcea792122a5a1d24e5b6dd370e6cc3

STR:
With a new profile, visit about:welcome
Click on the Screenshots card
Observe that the button doesn't do anything - it should open a new tab and take you to a screenshots tour
Depends on: 1496357
Pushed by usarracini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d9f06d99e8e
Use 'args' in button_action params to fix busted simplified onboarding actions r=k88hudson
https://hg.mozilla.org/mozilla-central/rev/7d9f06d99e8e
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Please nominate this for Beta approval when you get a chance.
Flags: needinfo?(usarracini)
Flags: in-testsuite+
Keywords: regression
Comment on attachment 9021202 [details]
Bug 1503288 - Use 'args' in button_action params to fix busted simplified onboarding actions

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1496357

User impact if declined: New simplified Onboarding button actions will not work.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Changing a parameter name, not changing any logic

String changes made/needed: None
Flags: needinfo?(usarracini)
Attachment #9021202 - Flags: approval-mozilla-beta?
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/8ac0438ddfb5ea7a9ff3d771501d9bce55e1af91
Backport Bug 1503288 - Use 'args' in button_action params to fix busted simplified onboarding actions (#4538)

* Backport Bug 1503288 - Use 'args' in button_action params to fix busted simplified onboarding actions

* Rename OnbardingMessage.test.jsx to OnboardingMessage.test.jsx

* New line at the end of OnboardingMessage.schema.json
Flags: qe-verify+
Comment on attachment 9021202 [details]
Bug 1503288 - Use 'args' in button_action params to fix busted simplified onboarding actions

[Triage Comment]
Updates the name of a parameter to fix onboarding. Approved for 64.0b6.
Attachment #9021202 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I reproduced this issue using Fx 65.0a1 (2018-10-30), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 65.0a1 (2018-11-02) and Fx 64.0b6, on Windows 10 x64, macOS 10.13.6 and Ubuntu 16.04 LTS.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Component: Activity Streams: Newtab → Messaging System
Iteration: --- → 64.3 - Oct 12
You need to log in before you can comment on or make changes to this bug.