1503289 - Redundant horizontal and vertical delimitation lines in about/addons /Themes section context menu

Status: NEW

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Vlad Lucaci, Desktop QA (:vlucaci)]

[Affected versions]:
- 64.0b5
- 63.0
- 65.0a1

[Affected platforms]:
- macOS 10.13.6
- Mac OS X 10.10.5
- Windows 10 x64
- Ubuntu 16.04 x64
- Windows 8.1 x32

[Steps to reproduce]:
1. Launch Firefox
2. Go to about:addons
3. Go to the Themes section
4. Right click on any of the available themes.

[Expected result]:
- The context menu should not display any redundant horizontal and vertical lines.

[Actual result]:
- The context menu displays a redundant horizontal line at the end of the context menu on Mac platform. For Windows platforms, a vertical line is also displayed alongside the horizontal one.

[Regression range]:
- Will return with regression range ASAP..

[Attachments]:
- Horizontal+Vertical lines on Windows Platform : https://drive.google.com/file/d/1HeKFlTdWeks8HLHVB4YY66toJTe5E1-i/view?usp=sharing

- Horizontal line on macOS platform:
https://drive.google.com/file/d/1rX90gVDv32-5fliUPGCU7-ypdriQbvYT/view?usp=sharing

Comment 1

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

I have returned with confirmation that this is indeed a regression:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bca1d807b8ad07d639d200c02aae0e050ff30dc7&tochange=9be8c32a4c59187abee7374ee54609498cf8503b

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Zombie, it looks like this was caused by bug 1422605. Can you investigate?

Comment 3

[Tomislav Jovanovic :zombie]

I'll take a closer look tomorrow, though it's seems very unlikely this is related to bug 1422605, despite the title, it had nothing to do with how context menus are constructed.

Also, I'm unable to access the attachments from desktop.

Comment 4

[Tomislav Jovanovic :zombie]

(In reply to Tomislav Jovanovic :zombie from comment #3)
> attachments from desktop.

from Dropbox.

Comment 5

[Vlad Lucaci, Desktop QA (:vlucaci)]

https://drive.google.com/file/d/1HeKFlTdWeks8HLHVB4YY66toJTe5E1-i/view?usp=sharing - Horizontal and Vertical lines on Windows

https://drive.google.com/file/d/1rX90gVDv32-5fliUPGCU7-ypdriQbvYT/view?usp=sharing - Horizontal line on macOS

Hello Tomislav, 
Above you will find the attachments that can be accessed.

Comment 6

[Tomislav Jovanovic :zombie]

On second look, this is probably leftover from bug 1311145.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 65 and 66 so that these already triaged issues don't show up repeatedly in weekly regression triage. Happy to take a patch in nightly.

Comment 8

[Jonathan Kingston [:jkt] he/him]

Removing ni, sorry I missed this.