1503308 - Make hgmo extensions compatible with Mercurial 4.8

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, enhancement)

Description

[Connor Sheehan [:sheehan]]

It appears this may take more work than all the other extensions. Filing a separate bug as there will likely be a small series of patches to apply.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: hgmo: remove compatibility with Mercurial 4.6 (Bug 1503308) r?gps

This function call changed between 4.6-4.7, and also changed
between 4.7-4.8. Rather than have an ever-increasing number
of method signatures to call, let's just remove the obsolete
4.6 version.

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: hgmo: add no-op arguments to `allparents` call under 4.8 (Bug 1503308) r?gps

In the previous commit we removed the 4.6 version of this
function, and in this commit we add the 4.8 version. The
new signature takes `context` and `mapping` to align
with other templatekeywords, however neither are used
as the function will take `ctx` from the closure instead.
We pass `None` as both arguments and function executes as
expected.

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: hgmo: convert repo path to byte string (Bug 1503308) r?gps

Under Mercurial 4.8, the repo path passed to the
`hg.repository` constructor must be string-like
instead of unicode (the format the data is in while
in the `data` dict). Converting to `bytes` aligns
us with the conversions in this function and makes
the hgmo extension compatible with Mercurial 4.8.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/729096878cc2
hgmo: remove compatibility with Mercurial 4.6 r=gps
https://hg.mozilla.org/hgcustom/version-control-tools/rev/67f34c42ba3d
hgmo: add no-op arguments to `allparents` call under 4.8 r=gps
https://hg.mozilla.org/hgcustom/version-control-tools/rev/eba8a6936653
hgmo: convert repo path to byte string r=gps