Revise text displayed on error when writing the update preferences file

RESOLVED FIXED in Firefox 69

Status

()

enhancement
P3
normal
RESOLVED FIXED
9 months ago
Yesterday

People

(Reporter: bytesized, Assigned: rstrong)

Tracking

(Depends on 1 bug)

unspecified
mozilla69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(2 attachments)

Bug 1458308 added an error message to be displayed if the update preferences file could not be written. However, UX never provided feedback on that error message. We should, therefore, consider revising that error message to be something a bit more user friendly.

The relevant strings, as they exist now, are:
update-pref-write-failure-title = Write Failure
update-pref-write-failure-message = Unable to save preference. Could not write to file: { $path }

Some relevant discussion on this topic took place between Bug 1458308 Comment 12 and Bug 1458308 Comment 15.
Flags: needinfo?(brjones)
Depends on: update-prefs
See Also: update-prefs

Clearing needinfo since brjones doesn't appear to be active anymore. I'll find out who we should needinfo from UX.

Flags: needinfo?(brjones)

Anthony, I have a couple of bugs that need UX input for strings. I'm not sure who from UX I should ask so could you please assign a UX person for this bug and bug 336267? Thanks!

Flags: needinfo?(alam)

Sorry I don't have the context here and I'm having trouble following along.

The best way to help us understand how we can help is probably to ping us on Slack or #ux :)

But if this has something to do with our Mobile products, I'd defer to Tiffanie Shakespeare and other members of her team there. N

Flags: needinfo?(alam)
Priority: -- → P3
Flags: needinfo?(mheubusch)
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED

Working with mheubusch we came up with the following strings for this bug
Robert Strong <rstrong@mozilla.com>

Wed, May 22, 10:13 PM (2 days ago)

to Kirk
I went ahead and made the following suggestions in reply to Michelle's message. I'm not terribly happy with the suggested course of action but I don't think it would be appropriate to not provide any suggested course of action.

A couple of notes:
We default to true when the file is missing or changed into a format that is incompatible so it won't show an error for those conditions. This is why I removed everything after "and" in the second sentence.

Most update preferences are stored using the typical method that preferences are stored in Firefox and there is only one update preference stored in this file currently. This is why I changed "Note that update preferences" to "Note that setting this update preference" in the second sentence.

We have mitigations in place that attempt to fix the permissions which should have the Users group having full control so it should be extremely rare that this UI is shown. We've had no reports of this UI being shown so far and it has been on release for at least one cycle. If a user does encounter this error it is extremely likely that they will need to do more than just fix the permissions of this one file. I've change the text to provide a little more detail as to what they would need to do and though I'm not that happy with it I don't know what else could be provided without it going into a ton of details.

Title: Error saving Update preferences
Body: <short name> encountered an error and didn’t save this change. Note that setting this update preference requires permission to write to the file below. You or a system administrator may be able resolve the error by granting the "Users" group full control to this file.

Could not write to file: { $path }

Flags: needinfo?(mheubusch)
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7317c8900a8b
Use UX provided text for displaying errors when writing the update settings json file. r=bytesized,flod
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #4)

Body: <short name> encountered an error and didn’t save this change. Note that setting this update preference requires permission to write to the file below. You or a system administrator may be able resolve the error by granting the "Users" group full control to this file.

I think a to is missing in the above string:
"You or a system administrator may be able to resolve the error..."

Flags: needinfo?(robert.strong.bugs)
QA Whiteboard: [qa-69b-p2]

I am fairly certain I copied and pasted the string I was given. I filed bug 1567396 for this.

Flags: needinfo?(robert.strong.bugs)
You need to log in before you can comment on or make changes to this bug.