1503381 - Improve styling for unfocused+selected tree item in bookmarks panel

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

Attachment: Screen Shot 2018-10-30 at 9.01.28 PM.png

Right now, it's a light gray, but it could use var(--arrowpanel-dimmed).

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1503381 - Improve styling for unfocused+selected tree item in bookmarks panel. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3eb1350f63d
Improve styling for unfocused+selected tree item in bookmarks panel. r=dao

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f3eb1350f63d

Comment 4

[laszlo.bialis]

Attachment: Screenshot 2019-03-22 at 17.30.10 FF64.png

Comment 5

[laszlo.bialis]

Attachment: Screenshot 2019-03-22 at 17.31.45.png

Comment 6

[laszlo.bialis]

Hi Tim,

I've tried to check the above issue both on macOS 10.13 and 10.14 on the latest Release 66 by comparing it to a Release 64. I've tried by setting the browser to dark mode and accessing the add bookmarks drop down, as suggested from the attached file. However the only difference I've seen was the background of the list which in 64 is white and now it is dark as in the attached files.

Is this the expected behavior? If not could you give me some clues on how to reproduce this? Thanks

Comment 7

[Tim Nguyen :ntim]

(In reply to laszlo.bialis from comment #6)

Hi Tim,

I've tried to check the above issue both on macOS 10.13 and 10.14 on the latest Release 66 by comparing it to a Release 64. I've tried by setting the browser to dark mode and accessing the add bookmarks drop down, as suggested from the attached file. However the only difference I've seen was the background of the list which in 64 is white and now it is dark as in the attached files.

Is this the expected behavior? If not could you give me some clues on how to reproduce this? Thanks

In attachment 9021316 [details], the background behind "Other bookmarks" is light gray when it should be semi-transparent.

To get the item in that state, you have to select the item, and then click outside the tree.

Note that this is only reproducible in the build between bug 1502731 and this bug.

Comment 8

[laszlo.bialis]

65.0a1 20181031100345 20190324214519
(In reply to Tim Nguyen :ntim from comment #7)

(In reply to laszlo.bialis from comment #6)

Hi Tim,

I've tried to check the above issue both on macOS 10.13 and 10.14 on the latest Release 66 by comparing it to a Release 64. I've tried by setting the browser to dark mode and accessing the add bookmarks drop down, as suggested from the attached file. However the only difference I've seen was the background of the list which in 64 is white and now it is dark as in the attached files.

Is this the expected behavior? If not could you give me some clues on how to reproduce this? Thanks

In attachment 9021316 [details], the background behind "Other bookmarks" is light gray when it should be semi-transparent.

To get the item in that state, you have to select the item, and then click outside the tree.

Note that this is only reproducible in the build between bug 1502731 and this bug.

Thanks for the details! Indeed I could reproduce this issue only on Nightly 65.0a1 20181031100345 on macOS 10.14 with the details above. I can confirm that the issue is fixed on the latest Nightly 68.0a1 20190324214519 and Release 66.0.1.