1503386 - FxR java.net.URISyntaxException: at java.net.URI$Parser.fail(URI.java)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Chris Peterson [:cpeterson]]

bp-39620cc0-e2b2-494b-9640-23fa20181030

There appear to be two different URI problems when FxR is uploading page load telemetry:

1. URL fragments with embedded # characters:

java.net.URISyntaxException: Illegal character in fragment at index 46: http://www.87870.com/gamelist/1704/20366.html###

2. URLs with other "illegal characters", but I don't see any problems with the characters at the specified indexes, e.g.

java.net.URISyntaxException: Illegal character in query at index 221: https://sspintrafmsmt.com/v/68c020bc-dbf2-11e8-b4cc-01018f287aed/c/cfc996c2-9783-11e5-b565-02f6361de079/?subid=6617984024054857854&pubid=5855&_i=1&_s=68bfe430-dbf2-11e8-9e19-01018f287a8c&_r=offers.wildbearads.bid&_n=&_d=7|1|300|1|1|1|t|t|800x450|0|1|e|1|24|24|96|74-f19ff10c|0|0|374|1|3|t|t|0,0,0|en,en-US|Linux%20armv8l|aaaa0|20100101|5.0%20(Android%207.1.2)|1|4|192.168.1.217|u|t|t|t|w7lhv|WebGL%201.0|Qualcomm|Adreno%20(TM)%20530|ex:nq6ww|1|20181004100221|t|n|n|n|n|1385x779|0|0|t|0|1|t

	at java.net.URI$Parser.fail(URI.java:2856)
	at java.net.URI$Parser.checkChars(URI.java:3029)
	at java.net.URI$Parser.parseHierarchical(URI.java:3119)
	at java.net.URI$Parser.parse(URI.java:3061)
	at java.net.URI.<init>(URI.java:590)
	at java.net.URI.create(URI.java:852)
	at org.mozilla.vrbrowser.telemetry.TelemetryWrapper.uploadPageLoadToHistogram(TelemetryWrapper.java:213)
	at org.mozilla.vrbrowser.SessionStore.onPageStop(SessionStore.java:866)
	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:443)
	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:433)
	at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:79)
	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:356)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6143)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Daosheng, maybe you could dig into this?

Comment 2

[Daosheng Mu[:daoshengmu]]

We fixed it recently, https://github.com/MozillaReality/FirefoxReality/pull/595.

I have confirmed it, and it can be reproduced with the app from the Oculus store. With the current master build, it will not happen crashes anymore. I think users just need a new version update.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Thanks Daosheng!

Comment 4

[Chris Peterson [:cpeterson]]

status-geckoview64=unaffected

Comment 5

[Chris Peterson [:cpeterson]]

New FxR exception in GV 71.0a1 with this same java.net.URISyntaxException: at java.net.URI$Parser.fail(URI.java) crash signature, but different stack trace:

https://github.com/MozillaReality/FirefoxReality/issues/1844