150341 - [FIX]during login not able to type capital letters

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[rrk]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.0) Gecko/20020530
BuildID:    2002053012

during login not able to type  capital letters partially or fully

Reproducible: Always
Steps to Reproduce:
1.pl go to this URL and type any login name with fully or partially having
capital letters
2.
3.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Minimal testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

The problem is that "text-transform:lowercase" is inherited into the form
controls and into their anonymous children...

Should all form controls simply have 

text-transform: none

in forms.css?  It's a little counterintuitive for text-transform to inherit into
them... Or should we not be inheriting this into anonymous content in the first
place?

Comment 3

[Hixie (not reading bugmail)]

Why is it counter-intuitive?

But I don't mind us adding a (non-important) rule to forms.css for this, sure.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Such a style should be on the form controls.

Comment 5

[rods (gone)]

I can't do commercial build and this needs PSM for testing, over to kin

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: The fix

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 90210 [details] [diff] [review]
The fix

It might be better to put this in DIV_STRING and DIV_STRING_SINGLELINE in
nsGfxTextControlFrame2.cpp.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Wouldn't that make it impossible for content authors to actually specify a
text-transform on the <input> or <textarea> if they really want one?

Comment 9

[fantasai]

bz: It's not UA !important, it's just a regular UA rule. If author's specify 
text-transform on the form element, it will override the forms.css rule.

But the rule should be added to the appropriate blocks; there's no need for 
text-transform to be separated out.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: No new rule

I was referring to comment 7 in comment 8.  If we added the rule to those
strings there would be no way for page authors to override it.

Same fix as originally, without the new rule.

Comment 11

[Kathleen :Brade]

-->glazman

Daniel--how much of a difference would it make to put the style on the div
instead of in forms.css?  (See comment 7)

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

I think that the CSS rule option is better. Whatever we do, it does not change
the data entered in a textarea, only the rendering is changed.
So it makes sense, from my point of view to allow "text-transform: lowercase"
on an inout or a textarea.
/me votes in favor of the CSS rule as shown by Boris.

Comment 13

[Boris Zbarsky [:bzbarsky]]

glazou, is that an r=?  ;)

Comment 14

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 90388 [details] [diff] [review]
No new rule

yes, that's a r=glazman
naive question : any xul element like textbox affected by this too ?

Comment 15

[fantasai]

>any xul element like textbox affected by this too ?

Yes, since IIRC, XUL form inputs use <input>/<textarea> through an XBL binding.

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 90388 [details] [diff] [review]
No new rule

sr=roc+moz

Comment 17

[Boris Zbarsky [:bzbarsky]]

checked in

Comment 18

[Boris Zbarsky [:bzbarsky]]

*** Bug 109884 has been marked as a duplicate of this bug. ***