Closed
Bug 1503421
Opened 6 years ago
Closed 5 years ago
Context menus WebExtensions API
Categories
(Thunderbird :: Add-Ons: Extensions API, enhancement)
Thunderbird
Add-Ons: Extensions API
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(2 files)
82.05 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
29.44 KB,
patch
|
Details | Diff | Splinter Review |
This should be the same as the Firefox API but with different "contexts", and different arguments passed to listeners. https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Attachment #9032849 -
Flags: review?(philipp)
Assignee | ||
Comment 2•5 years ago
|
||
If it makes life any easier, here's the changes I made to the files I copied over from mozilla-central.
Comment 3•5 years ago
|
||
Comment on attachment 9032850 [details] [diff] [review] 1503421-mc-diff-1.diff Review of attachment 9032850 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this makes it a lot easier. r=philipp with the following question: ::: browser/components/extensions/child/ext-menus.js @@ -257,5 @@ > }, > }; > - > - const result = {}; > - if (context.extension.hasPermission("menus")) { What happened to the permission checking?
Updated•5 years ago
|
Attachment #9032849 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 4•5 years ago
|
||
In Firefox there's also the contextMenus permission which allows for some things but not others, which is why there's permission checking in various places. I didn't implement the contextMenus permission – the whole thing requires the menus permission.
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/04e98cdf2061 Context menus WebExtensions API; r=Fallen
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 66.0
Comment 6•5 years ago
|
||
Is there any possibility that this will eventually include adding menu items to the main menu rather than the context menu?
Looks good.:)
You need to log in
before you can comment on or make changes to this bug.
Description
•