1503436 - Adding a breakpoint w/ column offset to a minified file can pause many times in unexpected places

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Logan Smyth [:loganfsmyth]]

Originally reported in https://github.com/devtools-html/debugger.html/issues/5519

The issue is that our logic for taking the closest offset doesn't account for the fact that a single line may have many Debugger.Script objects, and currently adds breakpoints to the first/last offsets for _all_ of these scripts, which is much too aggressive. It should only use the script closest to the column.

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1503436 - Only add breakpoints to first/last offset of script if column is directly in script. r?jlast

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/792fd0ab86d1
Only add breakpoints to first/last offset of script if column is directly in script. r=jlast

Comment 3

[Andreea Pavel [:apavel]]

Backed out for failing damp at damp | debugger/custom.js

Push that started the failures https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=792fd0ab86d1c254369b5003cac95dc19590a9d4

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209277626&repo=autoland&lineNumber=1014

Backout: https://hg.mozilla.org/integration/autoland/rev/09e5201164c98469f6e50ddf2fe73a7e288123d8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/177ecd76cc15
Only add breakpoints to first/last offset of script if column is directly in script. r=jlast

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/177ecd76cc15