Closed Bug 1503476 Opened Last year Closed Last year

Port bug 1455924 to TB: Clean up Dark/Light theme CSS

Categories

(Thunderbird :: Theme, task)

task
Not set

Tracking

(thunderbird64 fixed, thunderbird65 fixed)

RESOLVED FIXED
Thunderbird 65.0
Tracking Status
thunderbird64 --- fixed
thunderbird65 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 2 obsolete files)

This is a clean up of some variables.
Attached patch 1503476-dark-light-cleanup.patch (obsolete) — Splinter Review
There should be no visible change. The patch removes variables in compacttheme.css and moves them to the mailGlue.js. Port of https://hg.mozilla.org/mozilla-central/rev/469e083ccd18793bec63a26b3ffd6dd47d78c810

The only difference is that I used hsla(240, 5%, 5%, .2) for the toolbar_bottom_separator because m-c uses now hsl(240, 5%, 5%) and this makes a hard bottom border of the toolbars. Before hsla(240, 5%, 5%, .1) was used in the variable.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9021418 - Flags: review?(jorgk)
Attached patch 1503476-dark-light-cleanup.patch (obsolete) — Splinter Review
This one is better. It doesn't remove the painting of the messageheader.
Attachment #9021418 - Attachment is obsolete: true
Attachment #9021418 - Flags: review?(jorgk)
Attachment #9021445 - Flags: review?(jorgk)
I updated the patch with bug 1503301 which makes the same for the tab_line:

https://hg.mozilla.org/mozilla-central/rev/b42e11eeef40
Attachment #9021445 - Attachment is obsolete: true
Attachment #9021445 - Flags: review?(jorgk)
Attachment #9021569 - Flags: review?(jorgk)
Comment on attachment 9021569 [details] [diff] [review]
1503476-dark-light-cleanup.patch v3

Straight forward port, lightly tested, seems OK. Sorry about the delay, but other fires were burning hotter. And you've changed the patch twice ;-)
Attachment #9021569 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5929093fee14
Port bug 1455924 and bug 1503301 to TB: Clean up Dark/Light theme CSS. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Comment on attachment 9021569 [details] [diff] [review]
1503476-dark-light-cleanup.patch v3

Bug 1455924 is also uplifted to beta.
Attachment #9021569 - Flags: approval-comm-beta?
Attachment #9021569 - Flags: approval-comm-beta? → approval-comm-beta+
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.