Open Bug 1503510 Opened Last year Updated 4 months ago

[meta] Add unit tests for Perfherder

Categories

(Tree Management :: Perfherder, task, P3)

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: igoldan, Assigned: igoldan)

References

(Depends on 1 open bug)

Details

(Keywords: meta, Whiteboard: [lang=js])

We continue to break Perfherder, as we didn't provide it with front-end unit tests- spending a few weeks on tests would avoid many headaches - do half ourselves, and half with community.

Work on this bug depends on bug 1450044, as we want our tests to work for React components, not Angular ones.
For every new component that was switched to React, we must accompany it with tests.
We're switching to Jest for unit tests in bug 1364045 shortly. Waiting for that bug would avoid having to rewrite any tests added here, and hopefully making testing of React less painful.
Depends on: 1364045
(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #0)
> For every new component that was switched to React, we must accompany it
> with tests.

:sclements could you plan your work to also include some basic unit tests for the refreshed code?
These tests don't have to be exhaustive. I.e. me and Joel are thinking 5 unit tests per area covering at least 1/2 of the functional use cases.

We're more interested in the new code to be testable, not that much in covering all edge cases.
Flags: needinfo?(sclements)
Yes :)
Flags: needinfo?(sclements)
(keeping in mind what Ed mentioned above)
No longer blocks: 1510944
Depends on: 1510944
Whiteboard: [lang=js]
Type: enhancement → task
Keywords: meta
Priority: P1 → P2
Summary: Add unit tests for Perfherder → [meta] Add unit tests for Perfherder
Assignee: nobody → igoldan
Status: NEW → ASSIGNED
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.