1503510 - [meta] Add unit tests for Perfherder

Status: RESOLVED INVALID

(Tree Management :: Perfherder, enhancement, P3)

Description

[Ionuț Goldan [:igoldan]]

We continue to break Perfherder, as we didn't provide it with front-end unit tests- spending a few weeks on tests would avoid many headaches - do half ourselves, and half with community.

Work on this bug depends on bug 1450044, as we want our tests to work for React components, not Angular ones.
For every new component that was switched to React, we must accompany it with tests.

Comment 1

[Ed Morley [:emorley]]

We're switching to Jest for unit tests in bug 1364045 shortly. Waiting for that bug would avoid having to rewrite any tests added here, and hopefully making testing of React less painful.

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #0)
> For every new component that was switched to React, we must accompany it
> with tests.

:sclements could you plan your work to also include some basic unit tests for the refreshed code?
These tests don't have to be exhaustive. I.e. me and Joel are thinking 5 unit tests per area covering at least 1/2 of the functional use cases.

We're more interested in the new code to be testable, not that much in covering all edge cases.

Comment 3

[Sarah Clements [:sclements]]

Yes :)

Comment 4

[Sarah Clements [:sclements]]

(keeping in mind what Ed mentioned above)

Comment 5

[Ionuț Goldan [:igoldan]]

This ticket is too generic. The current workflow we follow mandates that every new PR has test coverage.
Thus contributing to this ticket.
We're better off by simply closing this as INVALID.