Closed
Bug 1503541
Opened 6 years ago
Closed 6 years ago
XCUITests: Re-enable drag and drop (on tab tray) tests on iPhone
Categories
(Firefox for iOS :: Build & Test, enhancement)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: isabel_rios, Assigned: isabel_rios)
Details
Attachments
(1 file)
These tests were disabled when the feature was off due to the unkown crashes.
Now the feature is on again and the tests for iPad are correctly enabled. For iPhone we need to modify the test suite since it was defined to run only for iPad while there are some tests that also apply for iPhone.
Due to that the test suite is failing now when running the scheduled build.
So, we would need to modify:
class DragAndDropTests: BaseTestCase
and add:
class DragAndDropTestIpad: IpadOnlyTestCase
for those tests that only apply to iPad
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → irios.mozilla
Attachment #9021621 -
Flags: review?(npark)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9021621 [details] [review]
GitHub Pull Request
LGTM
Attachment #9021621 -
Flags: review?(npark) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/20e40141ac5721449b89c98cf6117ce27d28c4e3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•