1503613 - mach xpcshell-test should show command in shell syntax

Status: RESOLVED FIXED

(Testing :: Python Test, defect)

Description

[Jim Blandy :jimb]

xpcshell-test should show each xpcshell command it executes using Unix shell syntax, so that developers can copy and paste the command into their shell for debugging.

Comment 1

[Jim Blandy :jimb]

Attachment: Bug 1503613: Make 'mach xpcshell-test' print the command in shell syntax. r?ted

When passed the `--verbose` flag, `mach xpcshell-test` already prints the
current directory, environment variables, and command used for the test.
However, it prints them in Python syntax. This seems like a good thing to do, as
it's a clear indication of what the test is actually doing. But if one wants to
reproduce a problem by running the xpcshell command directly, it's an
error-prone pain to convert from Python lists of strings to the Bourne shell
syntax.

Fortunately, the Python 2.7 `pipes` module has a function, `pipes.quote`, which
produces properly quoted Unix shell commands, ready to be copied and pasted into
one's terminal.

Unfortunately, the xpcshell tests still clean up the $obj/temp/xpc-plugins-FOO
directory, so this still isn't quite ready to go.

Comment 2

[Jim Blandy :jimb]

... Well, the patch is still useful and ready to go. It's just that it's not quite a seamless experience yet.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/821643f00719
Make 'mach xpcshell-test' print the command in shell syntax. r=ted

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/821643f00719