1503617 - Intermittent TV toolkit/mozapps/extensions/test/browser/browser_webapi_install.js | uncaught exception - ReferenceError: ok is not defined at popupshown@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1406:7

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=208930159&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/OXVjslc3SCSbPiW5Qjfqbw/runs/0/artifacts/public/logs/live_backing.log

[task 2018-10-31T16:29:47.597Z] 16:29:47     INFO - TEST-START | toolkit/mozapps/extensions/test/browser/browser_webapi_install.js
[task 2018-10-31T16:29:47.948Z] 16:29:47     INFO - GECKO(1061) | 1541003387936	addons.xpi	DEBUG	Download started for https://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/amosigned.xpi to file /tmp/tmp-2a0.xpi
[task 2018-10-31T16:29:47.948Z] 16:29:47     INFO - GECKO(1061) | 1541003387937	addons.xpi	DEBUG	Download of https://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/amosigned.xpi completed.
[task 2018-10-31T16:29:47.964Z] 16:29:47     INFO - GECKO(1061) | 1541003387958	addons.repository	DEBUG	cacheAddons: enabled false IDs ["[e-mail]"]
[task 2018-10-31T16:29:48.006Z] 16:29:48     INFO - TEST-INFO | started process screentopng
[task 2018-10-31T16:29:48.514Z] 16:29:48     INFO - TEST-INFO | screentopng: exit 0
[task 2018-10-31T16:29:48.516Z] 16:29:48     INFO - Buffered messages logged at 16:29:47
[task 2018-10-31T16:29:48.518Z] 16:29:48     INFO - Entering test bound setup
[task 2018-10-31T16:29:48.519Z] 16:29:48     INFO - added preferences
[task 2018-10-31T16:29:48.520Z] 16:29:48     INFO - Leaving test bound setup
[task 2018-10-31T16:29:48.521Z] 16:29:48     INFO - Entering test bound 
[task 2018-10-31T16:29:48.523Z] 16:29:48     INFO - Console message: 1541003387936	addons.xpi	DEBUG	Download started for https://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/amosigned.xpi to file /tmp/tmp-2a0.xpi
[task 2018-10-31T16:29:48.526Z] 16:29:48     INFO - Console message: 1541003387937	addons.xpi	DEBUG	Download of https://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/amosigned.xpi completed.
[task 2018-10-31T16:29:48.528Z] 16:29:48     INFO - Console message: 1541003387958	addons.repository	DEBUG	cacheAddons: enabled false IDs ["[e-mail]"]
[task 2018-10-31T16:29:48.536Z] 16:29:48     INFO - Buffered messages finished
[task 2018-10-31T16:29:48.537Z] 16:29:48     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_webapi_install.js | uncaught exception - ReferenceError: ok is not defined at popupshown@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1406:7
[task 2018-10-31T16:29:48.537Z] 16:29:48     INFO - EventListener.handleEvent*promisePopupNotificationShown/<@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1412:5
[task 2018-10-31T16:29:48.537Z] 16:29:48     INFO - promisePopupNotificationShown@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1401:10
[task 2018-10-31T16:29:48.537Z] 16:29:48     INFO - testInstall@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_webapi_install.js:42:3
[task 2018-10-31T16:29:48.537Z] 16:29:48     INFO - async*@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_webapi_install.js:246:9
[task 2018-10-31T16:29:48.538Z] 16:29:48     INFO - async*withNewTab@resource://testing-common/BrowserTestUtils.jsm:111:24
[task 2018-10-31T16:29:48.538Z] 16:29:48     INFO - async*makeInstallTest/<@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_webapi_install.js:168:11
[task 2018-10-31T16:29:48.538Z] 16:29:48     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1097:34
[task 2018-10-31T16:29:48.544Z] 16:29:48     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1088:16
[task 2018-10-31T16:29:48.550Z] 16:29:48     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:981:9
[task 2018-10-31T16:29:48.551Z] 16:29:48     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
[task 2018-10-31T16:29:48.552Z] 16:29:48     INFO - 
[task 2018-10-31T16:29:48.553Z] 16:29:48     INFO - Stack trace:
[task 2018-10-31T16:29:48.554Z] 16:29:48     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1635
[task 2018-10-31T16:29:48.555Z] 16:29:48     INFO - OnErrorEventHandlerNonNull*chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:null:1615
[task 2018-10-31T16:29:48.556Z] 16:29:48     INFO - chrome://mochikit/content/browser-test.js:Tester:395
[task 2018-10-31T16:29:48.558Z] 16:29:48     INFO - chrome://mochikit/content/browser-harness.xul:createTester/</<:251
[task 2018-10-31T16:29:48.560Z] 16:29:48     INFO - GECKO(1061) | JavaScript error: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js, line 1406: ReferenceError: ok is not defined
[task 2018-10-31T16:29:48.562Z] 16:29:48     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-10-31T16:29:48.564Z] 16:29:48     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_webapi_install.js | uncaught exception - ReferenceError: ok is not defined at popupshown@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1406:7
[task 2018-10-31T16:29:48.565Z] 16:29:48     INFO - EventListener.handleEvent*promisePopupNotificationShown/<@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1412:5
[task 2018-10-31T16:29:48.570Z] 16:29:48     INFO - promisePopupNotificationShown@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1401:10
[task 2018-10-31T16:29:48.571Z] 16:29:48     INFO - testInstall@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_webapi_install.js:42:3
[task 2018-10-31T16:29:48.573Z] 16:29:48     INFO - async*@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_webapi_install.js:271:9
[task 2018-10-31T16:29:48.574Z] 16:29:48     INFO - async*withNewTab@resource://testing-common/BrowserTestUtils.jsm:111:24
[task 2018-10-31T16:29:48.575Z] 16:29:48     INFO - async*makeInstallTest/<@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_webapi_install.js:168:11
[task 2018-10-31T16:29:48.580Z] 16:29:48     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1097:34
[task 2018-10-31T16:29:48.581Z] 16:29:48     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1088:16
[task 2018-10-31T16:29:48.582Z] 16:29:48     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:981:9
[task 2018-10-31T16:29:48.583Z] 16:29:48     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
[task 2018-10-31T16:29:48.583Z] 16:29:48     INFO - 
[task 2018-10-31T16:29:48.585Z] 16:29:48     INFO - Stack trace:
[task 2018-10-31T16:29:48.587Z] 16:29:48     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1635
[task 2018-10-31T16:29:48.588Z] 16:29:48     INFO - OnErrorEventHandlerNonNull*chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:null:1615
[task 2018-10-31T16:29:48.589Z] 16:29:48     INFO - chrome://mochikit/content/browser-test.js:Tester:395
[task 2018-10-31T16:29:48.591Z] 16:29:48     INFO - chrome://mochikit/content/browser-harness.xul:createTester/</<:251
[task 2018-10-31T16:29:48.593Z] 16:29:48     INFO - GECKO(1061) | JavaScript error: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js, line 1406: ReferenceError: ok is not defined
[task 2018-10-31T16:29:48.595Z] 16:29:48     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-10-31T16:29:48.597Z] 16:29:48     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_webapi_install.js | uncaught exception - ReferenceError: ok is not defined at popupshown@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1406:7
[task 2018-10-31T16:29:48.603Z] 16:29:48     INFO - EventListener.handleEvent*promisePopupNotificationShown/<@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1412:5
[task 2018-10-31T16:29:48.605Z] 16:29:48     INFO - promisePopupNotificationShown@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1401:10
[task 2018-10-31T16:29:48.607Z] 16:29:48     INFO - testInstall@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_webapi_install.js:42:3
[task 2018-10-31T16:29:48.608Z] 16:29:48     INFO - async*@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_webapi_install.js:296:9
[task 2018-10-31T16:29:48.609Z] 16:29:48     INFO - async*withNewTab@resource://testing-common/BrowserTestUtils.jsm:111:24
[task 2018-10-31T16:29:48.609Z] 16:29:48     INFO - async*makeInstallTest/<@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_webapi_install.js:168:11
[task 2018-10-31T16:29:48.611Z] 16:29:48     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1097:34
[task 2018-10-31T16:29:48.612Z] 16:29:48     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1088:16
[task 2018-10-31T16:29:48.612Z] 16:29:48     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:981:9
[task 2018-10-31T16:29:48.612Z] 16:29:48     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
[task 2018-10-31T16:29:48.618Z] 16:29:48     INFO -

Comment 1

[Noemi Erli[:noemi_erli]]

This started while Bug 1294235 landed: 
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=08ce1617c4819700220f03329bb6717dc3f20bf8&selectedJob=208913605

Comment 2

[Intermittent Failures Robot]

41 failures in 575 pushes (0.071 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 11
* autoland: 11
* mozilla-central: 19

Platform breakdown:
* linux64: 9
* osx-10-10: 6
* windows10-64-nightly: 2
* macosx64-nightly: 2
* windows7-32: 9
* windows10-64: 9
* windows7-32-nightly: 2
* linux64-nightly: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1503617&startday=2018-10-31&endday=2018-10-31&tree=all

Comment 3

[Intermittent Failures Robot]

41 failures in 2978 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #46 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 11
* autoland: 11
* mozilla-central: 19

Platform breakdown:
* windows10-64: 9
* windows7-32-nightly: 2
* windows7-32: 9
* linux64: 9
* linux64-nightly: 2
* macosx64-nightly: 2
* windows10-64-nightly: 2
* osx-10-10: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1503617&startday=2018-10-29&endday=2018-11-04&tree=all

Comment 4

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Comment 5

[Rob Wu [:robwu]]

I encountered this issue while running browser/components/extensions/test/browser/browser_ext_user_events.js locally, even without TV.

There are two issues with the tests:

1. Sometimes promisePopupNotificationShown("addon-webext-permissions").then(...) is called when the test doesn't actually generate such a prompt.
2. The test does not await the result of the above promise, which prevents the issue from being detected in a normal way (this bug is an example of an alternative, non-obvious way to detect the bug).

I'm going to fix both issues for both tests.

Comment 6

[Rob Wu [:robwu]]

Attachment: Bug 1503617 - Fix intermittent failures in tests with permission prompts

Comment 7

[Intermittent Failures Robot]

22 failures in 469 pushes (0.047 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 6
• autoland: 11
• mozilla-inbound: 5

Platform breakdown:

• windows10-64-nightly: 1
• windows7-32: 8
• windows10-64: 7
• linux64: 3
• osx-10-10: 2
• windows7-32-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1503617&startday=2019-02-13&endday=2019-02-13&tree=all

Comment 8

[Intermittent Failures Robot]

22 failures in 2832 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 11
• mozilla-central: 6
• mozilla-inbound: 5

Platform breakdown:

• windows7-32-nightly: 1
• windows10-64: 7
• windows7-32: 8
• windows10-64-nightly: 1
• linux64: 3
• osx-10-10: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1503617&startday=2019-02-11&endday=2019-02-17&tree=all

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be7d037f26bf
Fix intermittent failures in tests with permission prompts r=rpl

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/be7d037f26bf