Closed
Bug 1503651
Opened 2 years ago
Closed 2 years ago
Drop audience flavor dimension
Categories
(Firefox Build System :: Android Studio and Gradle Integration, enhancement)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
This is part of Bug 1500607. The audience dimension reflects the MOZILLA_OFFICIAL subst. I like being explicit ("local" vs "official" product flavors) but we're really feeling the complexity as more folks start to dig deeper into the GeckoView Gradle configuration. Time to streamline!
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
This is looking fine in https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=208973236&revision=1a8fdfe83c79c22168f79aef9ffe0780f1b8752f. (The red jobs are 'cuz those ones don't support artifact builds. There's nothing here that's artifact-specific, though.)
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/764deec55545 Drop audience flavor dimension. r=petru
Comment 4•2 years ago
|
||
Backed out for failing android build bustages Push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=764deec55545a2e7e298f60c46c00cd72c2a6aab Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209272478&repo=autoland&lineNumber=3609 Backout: https://hg.mozilla.org/integration/autoland/rev/f66fc2252f52bc2906d330b14ed3613fd8141757
Flags: needinfo?(nalexander)
Assignee | ||
Comment 5•2 years ago
|
||
Not setting MOZILLA_OFFICIAL was an oversight, I believe, from when Bug 1475573 landed the Android x86 debug fuzzing job. Nothing depends on !MOZILLA_OFFICIAL and it's incongruent with the rest of the jobs built in automation, which do set MOZILLA_OFFICIAL.
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5d3fe899230 Pre: Set MOZILLA_OFFICIAL for Android x86 debug fuzzing. r=firefox-build-system-reviewers,chmanchester
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa696fdda925 Drop audience flavor dimension. r=petru
Comment 8•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f5d3fe899230 https://hg.mozilla.org/mozilla-central/rev/fa696fdda925
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Updated•2 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 65 → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•