1503673 - Use a other dropmarker icon after the removal of panel-dropmarker.png in bug 1502731

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

On Mac we used the panel-dropmarker.png which is removed now.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1503673-dropmarker.patch

Arshad, this is a Mac only bug. The dropmarker is in the edit address panel when you click on the star in message header. I also fixed the toolbarbutton dropmarker.

Comment 2

[Arshad Khan [:arshad]]

Comment on attachment 9021622 [details] [diff] [review]
1503673-dropmarker.patch

Review of attachment 9021622 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/osx/mail/editContactPanel.css
@@ +80,5 @@
>  }
>  
>  #editContactAddressBookList > .menulist-dropmarker > .dropmarker-icon {
> +  list-style-image: url(chrome://messenger/skin/icons/toolbarbutton-arrow.svg);
> +  -moz-context-properties: fill;

what does -moz-context-properties do?

::: mail/themes/osx/mail/messenger.css
@@ +646,5 @@
>    background-color: transparent !important;
>    margin: 1px;
>  }
>  
> +button .dropmarker-icon {

where can i find a button with dropmarker inside?

Comment 3

[Tim Nguyen :ntim]

Attachment: Black dropmarkers on dark theme

-.dropmarker-icon {
+button .dropmarker-icon {

I think this is what the change is fixing.

The "Get Messages" and "Write" buttons are <toolbarbutton>, so prefixing the rule with button will make sure the black icon is only set for <button> and not for <toolbarbutton>

Comment 4

[Tim Nguyen :ntim]

> ::: mail/themes/osx/mail/editContactPanel.css
> @@ +80,5 @@
> >  }
> >  
> >  #editContactAddressBookList > .menulist-dropmarker > .dropmarker-icon {
> > +  list-style-image: url(chrome://messenger/skin/icons/toolbarbutton-arrow.svg);
> > +  -moz-context-properties: fill;
> 
> what does -moz-context-properties do?

Setting this allows you to use the fill property directly from the CSS to modify the SVG fill.

Comment 5

[Richard Marti (:Paenglab)]

I can not more write than what Tim wrote in comment 3 and 4.

Comment 6

[Arshad Khan [:arshad]]

(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #3)
> Created attachment 9021889 [details]
> Black dropmarkers on dark theme
> 
> -.dropmarker-icon {
> +button .dropmarker-icon {
> 
> I think this is what the change is fixing.
> 
> The "Get Messages" and "Write" buttons are <toolbarbutton>, so prefixing the
> rule with button will make sure the black icon is only set for <button> and
> not for <toolbarbutton>

Thanks ntim.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/53c3270b2956
On macOS use toolbarbutton-arrow.svg instead of panel-dropmarker.png removed in bug 1502731. r=arshad