1503674 - Do something with PageMetadataChild.jsm / PageMetadata.jsm

Status: RESOLVED FIXED

(Toolkit :: General, enhancement, P2)

Description

[Mark Banner (:standard8)]

PageMetadataChild.jsm is currently broken, and has been like it since it shipped in 63. This is because it has an incorrect import for ActorChild.jsm:

https://searchfox.org/mozilla-central/rev/eac6295c397133b7346822ad31867197e30d7e94/browser/actors/PageMetadataChild.jsm#9

(should be resource://gre/modules/ActorChild.jsm rather than resource://gre/actors/ActorChild.jsm).

Digging deeper, the messages it is designed to receive are never actually sent (PageMetadata:GetPageData, PageMetadata:GetMicroformats).

The last user appears to have been the Social API & related code.

We should either fix this & use it, or remove it. I'd was going to go for removing it, but the references below imply we could possibly be intending on using it...

Related bugs/Docs:

- Bug 1245446 - Drop microdata because it never got added to the spec (I assume this is Microformats).
-- However, there's a new draft of the spec from April 2018: https://www.w3.org/TR/microdata/
- Bug 1141782 - Use PageMetadata in Reader Mode.

Comment 1

[:Gijs (he/him)]

Can you set a priority on this bug?

As the de facto owner of reader mode, I don't think we should worry about the reader mode impact here. We should just remove this stuff, as it's unused. People are contributing fixes to the reader mode code, which is more than I can say for PageMetadata.jsm.

Comment 2

[:Gijs (he/him)]

(plus, we could always resurrect it if there is a sudden interest in this being available to reader mode)

Comment 3

[Mark Banner (:standard8)]

I think this is probably P2 ish, maybe a P3, but it is dead so let's do something with it sooner.

Having spoken to Mike (de Boer) earlier in the week, we also think it is reasonable just to drop it and pull it back later if we decide we need it.

Comment 4

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f15ef6265b10a2dc0daaa2cfa6597b049b0f559a

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1503674 - Remove unused PageMetadata. r?Gijs

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1503674 - Remove unused microformats code. r?Gijs

Depends on D14678

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 1503674 - Remove now unused nsIScriptableUnescapeHTML.idl. r?hsivonen

Depends on D14679

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6824881d78a
Remove unused PageMetadata. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/11457d8b6163
Remove unused microformats code. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/dfbe4026a7c5
Remove now unused nsIScriptableUnescapeHTML.idl. r=hsivonen

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a6824881d78a
https://hg.mozilla.org/mozilla-central/rev/11457d8b6163
https://hg.mozilla.org/mozilla-central/rev/dfbe4026a7c5