Closed Bug 1503674 Opened 10 months ago Closed 8 months ago

Do something with PageMetadataChild.jsm / PageMetadata.jsm

Categories

(Toolkit :: General, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(3 files)

PageMetadataChild.jsm is currently broken, and has been like it since it shipped in 63. This is because it has an incorrect import for ActorChild.jsm:

https://searchfox.org/mozilla-central/rev/eac6295c397133b7346822ad31867197e30d7e94/browser/actors/PageMetadataChild.jsm#9

(should be resource://gre/modules/ActorChild.jsm rather than resource://gre/actors/ActorChild.jsm).

Digging deeper, the messages it is designed to receive are never actually sent (PageMetadata:GetPageData, PageMetadata:GetMicroformats).

The last user appears to have been the Social API & related code.

We should either fix this & use it, or remove it. I'd was going to go for removing it, but the references below imply we could possibly be intending on using it...

Related bugs/Docs:

- Bug 1245446 - Drop microdata because it never got added to the spec (I assume this is Microformats).
-- However, there's a new draft of the spec from April 2018: https://www.w3.org/TR/microdata/
- Bug 1141782 - Use PageMetadata in Reader Mode.
Can you set a priority on this bug?

As the de facto owner of reader mode, I don't think we should worry about the reader mode impact here. We should just remove this stuff, as it's unused. People are contributing fixes to the reader mode code, which is more than I can say for PageMetadata.jsm.
Flags: needinfo?(standard8)
(plus, we could always resurrect it if there is a sudden interest in this being available to reader mode)
I think this is probably P2 ish, maybe a P3, but it is dead so let's do something with it sooner.

Having spoken to Mike (de Boer) earlier in the week, we also think it is reasonable just to drop it and pull it back later if we decide we need it.
Flags: needinfo?(standard8)
Priority: -- → P2
Depends on D14678
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6824881d78a
Remove unused PageMetadata. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/11457d8b6163
Remove unused microformats code. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/dfbe4026a7c5
Remove now unused nsIScriptableUnescapeHTML.idl. r=hsivonen
Depends on: 1515102
You need to log in before you can comment on or make changes to this bug.